Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update prototypes in extension code #36

Closed
wants to merge 1 commit into from

Conversation

myfluxi
Copy link

@myfluxi myfluxi commented Apr 7, 2023

Fixes a few deprecation warnings such as

Return type of Tensor\Vector::getIterator() should either be compatible with
IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be
used to temporarily suppress the notice in Unknown on line 0

Fixes a few deprecation warnings such as

  Return type of Tensor\Vector::getIterator() should either be compatible with
  IteratorAggregate::getIterator(): Traversable, or the #[\ReturnTypeWillChange] attribute should be
  used to temporarily suppress the notice in Unknown on line 0
@github-actions
Copy link

github-actions bot commented Apr 7, 2023

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@myfluxi
Copy link
Author

myfluxi commented Apr 7, 2023

I have read the CLA Document and I hereby sign the CLA

@andrewdalpino
Copy link
Member

Hey this is great @myfluxi, I'll take a look at this ASAP

@FxNion
Copy link

FxNion commented Apr 27, 2023

Seems something is broken here ?

@myfluxi
Copy link
Author

myfluxi commented Apr 28, 2023

It is an unrelated test failing later in the process. This patch fixes some warnings which at least lets the extension compile during testing.

@mlocati
Copy link
Contributor

mlocati commented Sep 14, 2023

The problem with this PR is that the code in the ext directory is automatically generated by zephir starting from the code in the tensor directory.

So, the fix should be performed in the tensor directory, like I'm suggesting in #39 (in particular, see 49f8b9e).

@mlocati mlocati mentioned this pull request Sep 17, 2023
@andrewdalpino
Copy link
Member

Hey thanks fellas, much appreciated! Do we still need this code since we merged @mlocati's code?

@andrewdalpino
Copy link
Member

Closing this because I think this issue has been solved in a different PR.

@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants