Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gate test on feature it needs #558

Merged
merged 2 commits into from
Oct 31, 2023
Merged

gate test on feature it needs #558

merged 2 commits into from
Oct 31, 2023

Conversation

alexanderkjall
Copy link
Contributor

@tarcieri
Copy link
Member

Aah interesting, seems we don't currently CI that the tests pass with --no-default-features, which would be good to add around here:

https://github.com/RustCrypto/AEADs/blob/2209bca/.github/workflows/eax.yml#L50

tarcieri
tarcieri reviewed Oct 25, 2023
View reviewed changes
eax/tests/aes128eax.rs Outdated Show resolved Hide resolved
@tarcieri tarcieri merged commit cb63de7 into RustCrypto:master Oct 31, 2023
8 checks passed
@alexanderkjall alexanderkjall deleted the gate-test-on-feature-it-needs branch October 31, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexanderkjall @tarcieri