Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bring the overflow behavior in bit shifts in sync with std #395

Merged
merged 15 commits into from
Dec 13, 2023
Merged

Bring the overflow behavior in bit shifts in sync with std #395

merged 15 commits into from
Dec 13, 2023

Commits on Dec 12, 2023

  1. Add more benchmarks for shifts

    @fjarri
    fjarri committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    f949925 View commit details
    Browse the repository at this point in the history

  2. Inline some low-level ops

    @fjarri
    fjarri committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    8257838 View commit details
    Browse the repository at this point in the history

  3. Return the overflow status in const fn bit shifts, panic if overflow … 

    …occurred
    @fjarri
    fjarri committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    4dbb16c View commit details
    Browse the repository at this point in the history

  4. Make uint/shl.rs and shr.rs uniform

    @fjarri
    fjarri committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    5f9fd15 View commit details
    Browse the repository at this point in the history

  5. Adjust BoxedUint API

    @fjarri
    fjarri committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    90a21a8 View commit details
    Browse the repository at this point in the history

  6. Add shift benchmarks for BoxedUint

    @fjarri
    fjarri committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    36175ba View commit details
    Browse the repository at this point in the history

  7. Improve BoxedUint::shl/shr performance by performing operations inpla… 

    …ce when possible
    @fjarri
    fjarri committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    a17ef3b View commit details
    Browse the repository at this point in the history

  8. Add a specialized BoxedUint::shl1 implementation

    @fjarri
    fjarri committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    972f546 View commit details
    Browse the repository at this point in the history

  9. Iterate in forward direction to help with cache

    @fjarri
    fjarri committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    17145af View commit details
    Browse the repository at this point in the history

  10. Rename sh(r/l)1_with_overflow to *_with_carry

    @fjarri
    fjarri committed Dec 12, 2023
    Configuration menu
    Copy the full SHA
    1640e79 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2023

  1. Fix BoxedUint shift docstrings

    @fjarri
    fjarri committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    0ff9c43 View commit details
    Browse the repository at this point in the history

  2. Add BoxedUint::conditional_set_to_zero()

    @fjarri
    fjarri committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    3558f9a View commit details
    Browse the repository at this point in the history

  3. Document returning zero on overflow for BoxedUint shifts

    @fjarri
    fjarri committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    43af4e2 View commit details
    Browse the repository at this point in the history

  4. Remove an obsolete test

    @fjarri
    fjarri committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    18179e0 View commit details
    Browse the repository at this point in the history

  5. Typo fix in shift docstrings

    @fjarri
    fjarri committed Dec 13, 2023
    Configuration menu
    Copy the full SHA
    6ce585a View commit details
    Browse the repository at this point in the history