Improve naming of public API properties #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ashfurrow CI is not triggered here as well. May be cause PR is not pointing to |
|
Argh, no I just hadn't configured it properly 😞 I've fixed the issue and redelivered the PR creation webhook to circle to trigger the build. Sorry about that! |
c0diq
reviewed
Oct 16, 2018
| @@ -77,7 +77,7 @@ class ActionTests: QuickSpec { | |||
| .bind(to: enabled) | |||
| .disposed(by: disposeBag) | |||
|
|
|||
| action.executing | |||
| action.isExecuting | |||
| @@ -90,7 +90,7 @@ class ActionTests: QuickSpec { | |||
| action.elements.subscribe().disposed(by: disposeBag) | |||
| action.errors.subscribe().disposed(by: disposeBag) | |||
| action.enabled.subscribe().disposed(by: disposeBag) | |||
| action.executing.subscribe().disposed(by: disposeBag) | |||
| action.isExecuting.subscribe().disposed(by: disposeBag) | |||
mosamer
added a commit
that referenced
this pull request
Apr 22, 2019
Improve naming of public API properties
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first phase of public API cleanup as discussed on #120, it includes the following;
enabled~>isEnabledexecuting~>isExecutingworkFactoryand_enabledIf