Change inputs type to AnyObserver<Input>

[mosamer]

Re-opening #127, not sure what was blocking it 🤔 so rebased and created a new PR for review

This PR is implementing migration of inputs property from SubjectType ~> ObserverType as discussed on #120

It includes the following items;

• Change inputs type from InputSubject ~> AnyObserver
• Drop InputSubject
• Improved test cases for action inputs behavior

[freak4pc]

This looks great to me! 🎉 Awesome work.
I'm just not knowledgable enough with Action to make a call here, so let's wait for someone else here as well :)

[bobgodwinx]

This is awesome and AnyObserver does the job perfectly. Thanks @mosamer

[freak4pc]

Hey! Just realized this was merged to a branch called 4.0 :O
It doesn't exist on master. Can we fix this?

[ashfurrow]

@freak4pc I don't think we can change the target branch after we merge – is this okay as-is?

[freak4pc]

@ashfurrow Heya, I already cherry picked this: 5e7fb77

:-)

[mosamer]

Hi @freak4pc, I am not sure what are we trying to fix 🤔 This issue is part of Release-4.0 milestone Why do you need to pick it to master

[freak4pc]

I'm super confused - you've merged 3 PRs of yours lately. This was the only one aimed at a 4.0.0 branch. Everything else was part of master. I think it might be better to have a develop branch if you want to have a staging thing because otherwise it makes it super confusing.

Some of these milestone issues are 2-3 years old which also made me think it's a mistake.

[mosamer]

Sorry, I guess this confusion is a result of this 4.0 milestone being abandoned for a while. branch 4.0 is/was intended as a develop branch for 4.0 issues which are mainly major breaking changes, I am trying to get this done over the next few weeks hopefully

[freak4pc]

@mosamer We've already released 4.0.0 to provide support for RxSwift 5, so if you continue on that path we should:

1. Maybe cut a new (develop) branch from masster
2. Apply your changes over that
3. We can apply these changes as a minor 4.x release

[mosamer]

@freak4pc I am fine with 1 & 2. As for nr. 3, given these are breaking changes to public API are we fine releasing them as a minor 4.x release. wdyt? 🤔

[freak4pc]

Uhm I see. That's a tad tricky so I'm not 100% sure. We could bump to 5 but if that's the case maybe we should gather some more changes? Since 4 was just released now.