release: 0.40.9

manifest-beta.json

@@ -1,7 +1,7 @@
 {
     "id": "pdf-plus",
     "name": "PDF++",
-    "version": "0.40.8",
+    "version": "0.40.9",
     "minAppVersion": "1.5.8",
     "description": "The most Obsidian-native PDF annotation tool ever.",
     "author": "Ryota Ushio",

manifest.json

@@ -1,7 +1,7 @@
 {
     "id": "pdf-plus",
     "name": "PDF++",
-    "version": "0.40.8",
+    "version": "0.40.9",
     "minAppVersion": "1.5.8",
     "description": "The most Obsidian-native PDF annotation tool ever.",
     "author": "Ryota Ushio",

package.json

@@ -1,6 +1,6 @@
 {
     "name": "obsidian-pdf-plus",
-    "version": "0.40.8",
+    "version": "0.40.9",
     "description": "The most Obsidian-native PDF annotation tool ever.",
     "scripts": {
         "dev": "node esbuild.config.mjs",

src/bib.ts

@@ -212,7 +212,7 @@ export class BibliographyManager extends PDFPlusComponent {
 class BibliographyTextExtractor {
     doc: PDFDocumentProxy;
     pageRefToTextContentItemsPromise: Record<string, Promise<TextContentItem[]> | undefined>;
-    onExtractedCallback: (destId: string, bibText: string) => any;
+    onExtractedCallback?: (destId: string, bibText: string) => any;
 
     constructor(doc: PDFDocumentProxy) {
         this.doc = doc;
@@ -235,7 +235,7 @@ class BibliographyTextExtractor {
                         .then((bibInfo) => {
                             if (bibInfo) {
                                 const bibText = bibInfo.text;
-                                this.onExtractedCallback(destId, bibText);
+                                this.onExtractedCallback?.(destId, bibText);
                             }
                         })
                 );

src/main.ts

@@ -115,7 +115,16 @@ export default class PDFPlus extends Plugin {
 	}
 
 	async onunload() {
-		// Clean up the AnyStyle input files and their directory (.obsidian/plugins/pdf-plus/anystyle)
+		await this.cleanUpResources();
+	}
+
+	/** Perform clean-ups not registered explicitly. */
+	async cleanUpResources() {
+		await this.cleanUpAnystyleFiles();
+	}
+
+	/** Clean up the AnyStyle input files and their directory (.obsidian/plugins/pdf-plus/anystyle) */
+	async cleanUpAnystyleFiles() {
 		const adapter = this.app.vault.adapter;
 		if (Platform.isDesktopApp && adapter instanceof FileSystemAdapter) {
 			const anyStyleInputDir = this.getAnyStyleInputDir();
@@ -563,6 +572,11 @@ export default class PDFPlus extends Plugin {
 				this.vimrc = await this.app.vault.read(file);
 			}
 		}));
+
+		// Clean up other resources when the app quits
+		this.registerEvent(this.app.workspace.on('quit', async () => {
+			await this.cleanUpResources();
+		}));
 	}
 
 	registerOneTimeEvent<T extends Events>(events: T, ...[evt, callback, ctx]: OverloadParameters<T['on']>) {

src/patchers/pdf-internals.ts

@@ -1,4 +1,4 @@
-import { Component, MarkdownRenderer, Notice, TFile, debounce, setIcon, setTooltip, Keymap, Menu, Platform } from 'obsidian';
+import { Component, MarkdownRenderer, Notice, TFile, debounce, setIcon, setTooltip, Keymap, Menu, Platform, requireApiVersion } from 'obsidian';
 import { around } from 'monkey-around';
 import { PDFDocumentProxy } from 'pdfjs-dist';
 
@@ -202,6 +202,18 @@ const patchPDFViewerChild = (plugin: PDFPlus, child: PDFViewerChild) => {
                     }
                 }
 
+                // Fix for the Obsidian core issue where the "find next" button in the find bar has a wrong icon
+                // https://forum.obsidian.md/t/duplicate-up-arrow-up-displayed-when-searching-a-pdf-inside-obsidian/84403/3
+                const fixedApiVersion = '1.7.0';
+                const findNextButtonEl = this.findBar?.findNextButtonEl;
+                const findNextIconEl = findNextButtonEl.firstElementChild;
+
+                if (!requireApiVersion(fixedApiVersion)
+                    && findNextIconEl
+                    && findNextIconEl.matches('svg.lucide-arrow-up')) {
+                    setIcon(findNextButtonEl, 'lucide-arrow-down');
+                }
+
                 return ret;
             }
 

styles.css

@@ -530,6 +530,11 @@ body {
         padding: var(--size-4-3);
         font-size: var(--font-ui-medium);
 
+        /* Make text inside citation hover selectable (https://github.com/RyotaUshio/obsidian-pdf-plus/issues/252) */
+        -moz-user-select: text;
+        -webkit-user-select: text;
+        user-select: text;
+
         .bib-title {
             font-weight: bold;
             padding-bottom: var(--size-4-2);
@@ -597,4 +602,4 @@ body {
 body.pdf-plus-vim-hint-inverted {
     --pdf-plus-vim-hint-color: var(--text-on-accent);
     --pdf-plus-vim-hint-background-color: hsl(var(--accent-h), var(--accent-s), var(--accent-l));
-}
+}