Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved UX #912

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Improved UX #912

wants to merge 4 commits into from

Conversation

danjoa
Copy link
Member

@danjoa danjoa commented Jan 19, 2024

  • Removed redundant Travel UUID from "Details"
  • Removed redundant currency from "Price"
  • Pre-filled some fields on NEW

@danjoa danjoa requested a review from stewsk February 5, 2024 13:20
@danjoa
Copy link
Member Author

danjoa commented Feb 16, 2024

ping

@stewsk
Copy link
Collaborator

stewsk commented Nov 19, 2024

Removing CurrencyCode_code from the UI

  • breaks the UI test, as it explicitly refers to that field
  • changing the currency via the remaining currency field (shown automatically together with the number) behaves strange

-> to be clarified with Fiori/UI5 colleagues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stewsk stewsk Awaiting requested review from stewsk

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danjoa @stewsk