SapMachine (17): Cherry-pick 8329109: Threads::print_on() tries to print CPU time for terminated GC threads #1756
Conversation
|
Hello @RealCLanger, this pull request fulfills all formal requirements. |
src/hotspot/share/runtime/thread.cpp
Outdated
| } | ||
| cl.do_thread(WatcherThread::watcher_thread()); | ||
| cl.do_thread(AsyncLogWriter::instance()); | ||
| non_java_threads_do(&cl); | ||
|
|
||
| // SapMachine 2019-11-07: Vitals |
There was a problem hiding this comment.
I think L3868 - L3883 can be also removed. The vitals sampler thread and the himem reporter thread are NonJavaThreads and handled by non_java_threads_do(&cl); in L3866.
There was a problem hiding this comment.
Interesting, good catch. Then it's probably also wrong in head and the other higher backports, e.g.:
SapMachine/src/hotspot/share/runtime/threads.cpp
Line 1389 in 32cfd18
There was a problem hiding this comment.
Yes indeed. Likewise good catch.
…C threads Reviewed-by: rrich Backport-of: c1cfb43
|
Hello @RealCLanger, this pull request fulfills all formal requirements. |
| @@ -3589,7 +3589,6 @@ void Threads::add(JavaThread* p, bool force_daemon) { | |||
| p->set_on_thread_list(); | |||
|
|
|||
| _number_of_threads++; | |||
|
|
|||
There was a problem hiding this comment.
Other nit: empty line L3618 before closing brace doesn't look nice either. I'll leave it to you if you remove it.
There was a problem hiding this comment.
I removed this line only because it's a diff to upstream. 😉
We want to cherry-pick the backport of JDK-8329109 for the July CPU. Due to SapMachine diffs, the upstream patch did not apply cleanly, I had to massage it.
fixes #1502