feat(trustengine): Integrate Trust Engine into step config resolver #5032
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CCFenner
reviewed
Aug 30, 2024
CCFenner
reviewed
Sep 2, 2024
CCFenner
reviewed
Sep 2, 2024
CCFenner
reviewed
Sep 3, 2024
CCFenner
reviewed
Sep 3, 2024
jliempt
commented
Sep 3, 2024
Comment on lines
56
to
57
| - name: sonar | ||
| type: trustengineSecret |
There was a problem hiding this comment.
We should probably do this in a separate PR, so that the new functionality doesn't get activated yet.
jliempt
commented
Sep 3, 2024
CCFenner
reviewed
Sep 4, 2024
jliempt
changed the title
CCFenner
reviewed
Sep 6, 2024
Comment on lines
56
to
58
| - type: trustengineSecret | ||
| name: sonarTrustengineSecretName | ||
| default: sonar |
There was a problem hiding this comment.
Do you want to keep this or have a dedicated PR?
There was a problem hiding this comment.
This will go to a dedicated PR, it's just still here for testing purposes.
pkg/config/trustengine.go
Outdated
| config.Config[param.Name] = token | ||
| log.Entry().Info(" succeeded") | ||
| } else { | ||
| log.Entry().Debugf("Skipping getting '%s' from Trust Engine: parameter already set", param.Name) |
There was a problem hiding this comment.
This sounds weird, but I'm also no native speaker..
There was a problem hiding this comment.
I've changed it to Skipping retrieval of....
2 tasks
|
/it-go |
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Enables getting tool tokens from a Trust Engine API, if there is a hook configured to it. Such a hook should come from the default configuration.
The Trust Engine will only be used when the token hasn't been found in Vault (or passed in another way).
This PR adds the resource reference to a parameter that has the Trust Engine enabled.
And this one takes care of the documentation.