Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Common.DocumentationRef #306

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Common.DocumentationRef #306

merged 11 commits into from
Sep 19, 2024

Conversation

HeikoTheissen
Copy link
Contributor

No description provided.

HeikoTheissen
HeikoTheissen commented Feb 6, 2024
View reviewed changes
vocabularies/Common.xml Outdated Show resolved Hide resolved
uhlmannm
uhlmannm previously approved these changes Sep 17, 2024
View reviewed changes
ralfhandl
ralfhandl reviewed Sep 17, 2024
View reviewed changes
vocabularies/Common.json Outdated Show resolved Hide resolved
vocabularies/Common.json Show resolved Hide resolved
BerSie
BerSie reviewed Sep 18, 2024
View reviewed changes
vocabularies/Common.xml Outdated Show resolved Hide resolved
BerSie
BerSie previously approved these changes Sep 19, 2024
View reviewed changes
vocabularies/Common.xml Outdated Show resolved Hide resolved
uhlmannm
uhlmannm previously approved these changes Sep 19, 2024
View reviewed changes
ralfhandl
ralfhandl reviewed Sep 19, 2024
View reviewed changes
vocabularies/Common.xml Outdated Show resolved Hide resolved
ralfhandl
ralfhandl reviewed Sep 19, 2024
View reviewed changes
vocabularies/Common.xml Outdated Show resolved Hide resolved
ralfhandl
ralfhandl requested changes Sep 19, 2024
View reviewed changes
Copy link
Member

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is not a URL

BerSie
BerSie approved these changes Sep 19, 2024
View reviewed changes
Copy link
Member

@BerSie BerSie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

under the given circumstances it's OK for me, but I will never understand why we make nearly everything in our system accessible via (OData) URL, but our documentation (static texts) can't be directly addressed by URLs.

@HeikoTheissen HeikoTheissen merged commit 57d4aae into main Sep 19, 2024
3 checks passed
@HeikoTheissen HeikoTheissen deleted the Common.DocumentationRef branch September 19, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BerSie BerSie BerSie approved these changes

@uhlmannm uhlmannm uhlmannm approved these changes

@ralfhandl ralfhandl ralfhandl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@HeikoTheissen @ralfhandl @uhlmannm @BerSie