Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Node 22 #354

Merged
merged 3 commits into from
Oct 29, 2024
Merged

Add Node 22 #354

merged 3 commits into from
Oct 29, 2024

Conversation

ralfhandl
Copy link
Member

@ralfhandl ralfhandl commented Oct 29, 2024

Node 22 is now current, Node 20 is active LTS, see https://github.com/nodejs/release?tab=readme-ov-file#release-schedule

Copy link
Contributor

@HeikoTheissen HeikoTheissen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to run the build twice.

.github/workflows/nodejs.yml Outdated Show resolved Hide resolved
Co-authored-by: Heiko Theißen <heiko.theissen@sap.com>
@ralfhandl
Copy link
Member Author

No need to run the build twice.

Correct in this repo because we do not have any required status checks for PRs.

HeikoTheissen
HeikoTheissen previously approved these changes Oct 29, 2024
@HeikoTheissen
Copy link
Contributor

HeikoTheissen commented Oct 29, 2024

The build runs even if we do not specify a Node version (GitHub chooses node: v18.20.4). And if we do not require a specific one before merging, that should be sufficient.

@ralfhandl ralfhandl merged commit 13697e5 into main Oct 29, 2024
3 checks passed
@ralfhandl ralfhandl deleted the node-22 branch October 29, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants