Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update metadata definition for v2 requests #672

Merged
merged 2 commits into from
Jul 24, 2023
Merged

fix: update metadata definition for v2 requests #672

merged 2 commits into from
Jul 24, 2023

Conversation

nlunets
Copy link
Member

@nlunets nlunets commented Jul 24, 2023

Fix for #666 and #671

Seems like i don't like v2 after all :)

@changeset-bot
Copy link

changeset-bot bot commented Jul 24, 2023

🦋 Changeset detected

Latest commit: 3d08361

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/fe-mockserver-core Patch
@sap-ux/ui5-middleware-fe-mockserver Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@nlunets nlunets requested a review from a team July 24, 2023 12:04
@nlunets nlunets merged commit 2ecd0c5 into main Jul 24, 2023
12 checks passed
@nlunets nlunets deleted the v2Metadata branch July 24, 2023 12:10
@@ -971,6 +971,10 @@ export class DataAccess implements DataAccessInterface {
case 'Edm.Int64': {
return `${key}=${currentKeys[key]}`;
}
case 'Edm.Boolean':
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as the cases above, but ok for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants