Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui5-time-picker): add required, accessibleName & accessibleNameRef #9352

Merged
merged 6 commits into from
Jul 8, 2024

Conversation

didip1000
Copy link
Contributor

@didip1000 didip1000 commented Jul 1, 2024

With this change, users can now set required, accessible-name and accessible-name-ref properties for ui5-time-picker.

Required

This property defines if time pickers are required in forms. Time picker can be used in a form as follows:

<form>
    <ui5-time-picker required></ui5-time-picker>
    <ui5-button type="Submit">Submit</ui5-button>
</form>

Accessible Name

This property defines the aria-label for the time picker. In the following example, a screen reader will read out "Pick a time" when focused on the picker input:

<ui5-time-picker accessible-name="Pick a time"></ui5-time-picker>

Accessible Name Ref

Reference to other components that define the aria-label for the time picker. In the following example, a screen reader will read out "Pick a time" when focused on the picker input:

<ui5-label id="label">Pick a time</ui5-label>
<ui5-time-picker accessible-name-ref="label"></ui5-time-picker>

Closes: #5895

@didip1000 didip1000 requested a review from unazko July 3, 2024 06:06
@unazko unazko marked this pull request as ready for review July 4, 2024 06:50
packages/main/src/TimePicker.ts Outdated Show resolved Hide resolved
packages/main/src/TimePicker.ts Outdated Show resolved Hide resolved
@didip1000 didip1000 merged commit 08988c4 into main Jul 8, 2024
10 checks passed
@didip1000 didip1000 deleted the timepicker-required branch July 8, 2024 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TimePicker: add required and accessibleNameRef
4 participants