Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui5-date-picker): afjust timestamp #9355

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(ui5-date-picker): afjust timestamp #9355

wants to merge 1 commit into from

Conversation

unazko
Copy link
Contributor

@unazko unazko commented Jul 1, 2024

Fixes: 9217

nnaydenow
nnaydenow reviewed Jul 1, 2024
View reviewed changes
packages/main/src/DatePicker.ts
@@ -405,6 +405,9 @@ class DatePicker extends DateComponentBase implements IFormInputElement {
}

onResponsivePopoverBeforeOpen() {
if (this._calendar) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the _calendar getter you've put ! that means the query returns element always. If it's correct this expression is redundant otherwise the getter returns wrong result

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnaydenow nnaydenow nnaydenow left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ui5-date-picker]: wrong value when picker is reopen
2 participants
@unazko @nnaydenow