Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Implement password prompt as a standalone prompt #1353

Merged
merged 1 commit into from
Jan 27, 2024

Conversation

SBoudrias
Copy link
Owner

Extracted the core rewrite from #1334 (cc @matteosacchetto).

Since this other PR is blocked on finding the right key-binding, I want to unblock other work (like the theme branch) I punted upon to not heavily conflict with the rewrite. Separating the rewrite should reduce the friction 🤞🏻

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (c186dc2) 94.48% compared to head (0d9eb82) 94.48%.
Report is 1 commits behind head on master.

Files Patch % Lines
packages/password/src/index.mts 96.96% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1353      +/-   ##
==========================================
- Coverage   94.48%   94.48%   -0.01%     
==========================================
  Files          51       51              
  Lines        4423     4457      +34     
  Branches      772      775       +3     
==========================================
+ Hits         4179     4211      +32     
- Misses        239      241       +2     
  Partials        5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SBoudrias SBoudrias force-pushed the implement-standalone-password-prompt branch from 9964826 to 0d9eb82 Compare January 27, 2024 19:05
@SBoudrias SBoudrias merged commit 11bbb4b into master Jan 27, 2024
19 of 20 checks passed
@SBoudrias SBoudrias deleted the implement-standalone-password-prompt branch January 27, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants