Expose external-editor file options on the editor prompt
#1593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1593 +/- ##
=======================================
Coverage ? 96.83%
=======================================
Files ? 40
Lines ? 2368
Branches ? 644
=======================================
Hits ? 2293
Misses ? 67
Partials ? 8 ☔ View full report in Codecov by Sentry. |
- Updated editor prompt configuration to accept `file` options (`IFileOptions`) instead of only `postfix`, allowing for more flexible file handling within the editor's prompt. - Refactored test cases in `editor.test.ts` to accommodate the new file option structure.
bilalesi
force-pushed
the
feat/customize-editor-file-config
branch
from
780bc66
to
340f613
Compare
SBoudrias
reviewed
Nov 4, 2024
SBoudrias
reviewed
Nov 4, 2024
SBoudrias
reviewed
Nov 4, 2024
SBoudrias
approved these changes
Nov 11, 2024
SBoudrias
changed the title
external-editor file options on the editor prompt
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the editor plugin in macos raise an error due the directory path was not found, this PR will allow more flexibility to change the temporary file for the editor, by leveraging the
external-editoroptionsfileoptions (IFileOptions) instead of onlypostfix, allowing for more flexible file handling within the editor's prompt.editor.test.tsto accommodate the new file option structure.Error ex:
The path '/var/folders/kg/v5lhl9ps5d7_pc7l1_vggwv89zcpf2/T/tmp-19210mJVCVgQam7Er.json' does not exist on this computer.