Add unit tests for SingleJob and Results classes #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dormrod
force-pushed
the
DavidOrmrodMorley/SCMSUITE-8674.single_job_and_results_unit_tests
branch
from
d00f57d to
dd015e0
Compare
mhellstr
reviewed
Sep 3, 2024
unit_tests/test_basejob.py
Outdated
| There is also an option to add an arbitrary wait period before the job runs to simulate a longer-running calculation. | ||
| """ | ||
|
|
||
| def __init__(self, inp=None, cmd=None, wait=0.0, **kwargs): |
Interesting idea. I don't think I would want to put it with the production jobs code, but perhaps it is worth creating a For now I think I will leave as-is in the tests, until there are enough useful components that it would be worth breaking them out and including them in the package, or actually used by an example. The class itself is very thin anyway at the moment. |
dormrod
force-pushed
the
DavidOrmrodMorley/SCMSUITE-8674.single_job_and_results_unit_tests
branch
from
dd015e0 to
53d7d20
Compare
mhellstr
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add tests for the
SingleJobandResultsclasses. In addition include small refactoring.Refactorings
There are small refactorings here. Add a
StrEnumcalledJobStatusto explicitly define the different job status types. This is now used throughout the code. Note this is backwards compatible as string comparisons should all still work as previously.In addition add type hints to the Job and Result classes
Bugfix
One small bug fix flagged by tests -
Job.loaddid not actually return the loaded job, now it does.Tests
Otherwise add tests for the
SingleJobandResultsclasses. To facilitate this, add aDummySingleJobwhich runs a simple shell command, possibly with a wait. This allows testing of the job file generation and dependencies.