Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logger no longer errors when logfile path is invalid SCMSUITE-9740 SO107 #179

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

dormrod
Copy link
Contributor

@dormrod dormrod commented Dec 2, 2024

Description

Couple of small fixes/tweaks to the logger class.

  • Do not error if the logfile path is invalid (i.e. directory does not exist). This was also the previous plams behaviour so was an accidental regression
  • Use abspaths when comparing whether the logfile handler should be updated. This avoids recreating the handler too frequently when using relative paths

@dormrod dormrod force-pushed the DavidOrmrodMorley/default_logger_fix branch 2 times, most recently from e29fdf2 to 0fa8675 Compare December 2, 2024 11:45
@dormrod dormrod force-pushed the DavidOrmrodMorley/default_logger_fix branch from 0fa8675 to 80f673e Compare December 2, 2024 13:58
@dormrod dormrod merged commit ae6ccc6 into trunk Dec 2, 2024
17 checks passed
@dormrod dormrod deleted the DavidOrmrodMorley/default_logger_fix branch December 2, 2024 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants