-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add error messaging logging for ams jobs SO107 SCMSUITE-8725 #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dormrod
force-pushed
the
DavidOrmrodMorley/immediate-err-logging
branch
3 times, most recently
from
December 5, 2024 13:56
fb00d3b
to
4cb7e51
Compare
dormrod
force-pushed
the
DavidOrmrodMorley/immediate-err-logging
branch
from
December 5, 2024 14:08
4cb7e51
to
f559af6
Compare
dormrod
force-pushed
the
DavidOrmrodMorley/immediate-err-logging
branch
from
December 6, 2024 09:45
f205bde
to
6473fab
Compare
dormrod
commented
Dec 6, 2024
3, | ||
) | ||
|
||
assert mock_stdout.getvalue() == ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mhellstr
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Log any results of
AMSJob.get_errormsg
to the default logger at the end of the job.This makes it clear in the std output what may have gone wrong e.g.
Add a small tweak to
get_errormsg
to handle license issues, and small unit test.Note that this limits any error logs to 20 lines (arbitrary choice).
Also make the message
slightly less spammy by ignoring it when called from
ok
,check
orget_errormsg