Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add interface for per element operations #35

Draft
wants to merge 119 commits into
base: main
Choose a base branch
from
Draft

Add interface for per element operations #35

wants to merge 119 commits into from

Conversation

cwsmith
Copy link
Contributor

@cwsmith cwsmith commented Sep 26, 2024 •
edited
Loading

This includes:

  • definition of linear and quadratic shape functions for simplicies (edges, triangles, and tets)
  • support for user/application element-to-dof ordering and the subsequent index into the arrays holding field data - i.e., the user/application has a different definition of the ordering/numbering of dof holders in a triangle/tet than what MeshFields uses. Note, this PR does not yet include programmatic access to the built-in/native MeshFields canonical ordering for each type of element+shape function combination.
  • tests using dummy mesh and Omega_h data to exercise the APIs

Discussion:

  • is a test of the shape function values, as done in shapefun.cc from pumi, a good addition?
    • yes

Todo:

  • add test for tetrahedrons e118072
  • add test that creates a field over an omegah mesh and evaluates the field d49551c
  • add tests that check the results of the evaluate operation using
    • linear shape function @ centroid d49551c
    • linear shape function @ interior 82f3a4f
    • quadratic shape function @ centroid 34b26b3
    • quadratic shape function @ interior 34b26b3
    • quadratic shape function with linear analytic function @ interior 34b26b3
  • add helper method that writes the field to Omega_h tags for rendering/etc.
  • extend evaluate to accept a multiple points per element 2535f17
  • documentation - class/struct interaction
  • documents - nomenclature
  • add static asserts for templated interfaces and classes
  • test with cabana controller - WIP in cws/CabBackend

@cwsmith
don't repeat yourself
872abd4
@cwsmith
initial element interface
4903d9e 
copied from cws/cavityOp prototype code
@cwsmith
move shape functions to their own header
46b49cc
@cwsmith
todo
934a146
@cwsmith
pass field to fieldElement
c5e76c7
@cwsmith
mem error note
5e593ee
@cwsmith
add map functor
3346ffa
@cwsmith
memory error fixed
23d8d53
@cwsmith
one namespace 'MeshField'
8acf93b
@cwsmith
remove hardcoded types and sizes
cc5d2dd
@cwsmith
pass rank 2 view of coordinates
c95193a
@cwsmith
set array
b8b26e0 
evaluate could not access Element::Shape::meshEntDim so I defined MeshEntDim in FieldElement; there is probably a better way
@cwsmith
not using kokkos_stdalgorithms
90a1295
@cwsmith
whitespace
4c63fcf
@cwsmith
quadratic tri WIP
60d591d
@cwsmith
compiles
6817a44 
need template template parameter to get the nested type
@cwsmith
wip: create quadratic tri element
2865d95
@cwsmith
compiles
b144dfb
@cwsmith
loop over topology to support quadratic elm
20a6891
@cwsmith
wip: create field based on distribution
0148f99
@cwsmith
first pass at field creation helper function
a87fe0e
@cwsmith
use meshinfo struct
a5b8f1d
@cwsmith
todo
c0a5796
@cwsmith
evaluate: support dofs with multiple components
a4a80fa
@cwsmith
todo
368e104
@cwsmith
handle quadratic fields... wip
ad87418
@cwsmith
more prototyping
a7879cb
@cwsmith
mixins for multi field access... WIP
4e4b82c
@cwsmith
use the field creation interface
d020e7b
@cwsmith
more
1bf12ae
@cwsmith
Copy link
Contributor Author

cwsmith commented Dec 5, 2024

/runtests

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Test Result: failure (details)

@cwsmith
Copy link
Contributor Author

cwsmith commented Dec 5, 2024

/runtests

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Test Result: failure (details)

@cwsmith
Copy link
Contributor Author

cwsmith commented Dec 5, 2024

/runtests

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Test Result: failure (details)

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 9, 2024
View reviewed changes
test/testOmegahElement.cpp
template <size_t NumPtsPerElem>
Kokkos::View<MeshField::Real *[3]>
createElmAreaCoords(size_t numElements,
Kokkos::Array<MeshField::Real, 3 * NumPtsPerElem> coords) {

Check notice

Code scanning / CodeQL

Large object passed by value Note test

This parameter of type
Array<double, 9UL, void>
Loading
is 72 bytes - consider passing a const pointer/reference instead.
test/testOmegahElement.cpp Fixed Show fixed Hide fixed
test/testOmegahElement.cpp Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 9, 2024
View reviewed changes
test/testOmegahElement.cpp
TestCoords{allVertices, ThreePtsPerElem, "allVertices"}};
// clang-format on

static const size_t LinearField = 1;

Check notice

Code scanning / CodeQL

Unused static variable Note test

Static variable LinearField is never read.
test/testOmegahElement.cpp
// clang-format on

static const size_t LinearField = 1;
static const size_t QuadraticField = 2;

Check notice

Code scanning / CodeQL

Unused static variable Note test

Static variable QuadraticField is never read.
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 11, 2024
View reviewed changes
src/MeshField.hpp

Field(Slice s) : slice(s) {}
Field(Slice s) : slice(s), divisors(computeDivisors()) {}

Check notice

Code scanning / CodeQL

Large object passed by value Note

This parameter of type
KokkosSliceWrapper<View<long *****, HostSpace>, long *****>
Loading
is 72 bytes - consider passing a const pointer/reference instead.
This parameter of type
KokkosSliceWrapper<View<int *****, HostSpace>, int *****>
Loading
is 72 bytes - consider passing a const pointer/reference instead.
@github-actions GitHub Actions
Copy link

Package Line Rate Complexity Health
...build-kokkos.install.include 65% 0 ➖
...build-kokkos.install.include.Serial 97% 0 ✔
...build-kokkos.install.include.View.Hooks 100% 0 ✔
...build-kokkos.install.include.View 88% 0 ✔
...build-kokkos.install.include.desul.atomics 100% 0 ✔
...build-kokkos.install.include.impl 75% 0 ✔
...build-omegah.install.include 27% 0 ❌
meshFields.src 92% 0 ✔
meshFields.test 92% 0 ✔
Summary 84% (1993 / 2371) 0 ✔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cwsmith