vertex based patch creation #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doesn't support more than one expansion round for now
The elmsInPatch-to-2ndAdjElms graph was being created and returned. It was not 'merging' those subgraphs into the patch-to-elmsInPatch graph that needs to be returned.
use graph functions nnodes and nedges
given the use of kokkos team sorting, the patch api is only supported when kokkos is enabled
moved to Omega_h_patches.[h|c]pp
|
/runtests |
|
Test Result: success (details) |
jacobmerson
reviewed
Nov 9, 2024
There was a problem hiding this comment.
I think it might be helpful to have a couple comments in the expandPatches function that explains the steps of the algorithm.
Is the naming convention you are using functions in the anonymous namespace use underscores and other functions are camel case? That's fine just wasn't positive if there is something else I wasn't grokking.
jacobmerson
approved these changes
Dec 3, 2024
|
Thanks for adding the docs. I am fine with including this if you are ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for creation of small sets of elements (the highest dimension mesh entity,
dim) surrounding each vertex in the mesh. The patches are formed by first collecting the upward adjacent elements to each vertex and then successively adding elements to the patch that are adjacent to the current elements via sides (entities of dimensiondim-1) until the minimum patch size is reached for each vertex. For use with a partitioned mesh, the mesh partition needs to be created with ghosting enabled (i.e.,mesh.set_parting(OMEGA_H_GHOSTED)).Note, Kokkos is required for shared memory parallel segment sorting via team sort.
This functionality is needed to support super convergent patch recovery for the BER land ice project.