Fix the transition visual jump between placeholderImage and final image for AnimatedImage #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dreampiggy
commented
Jul 1, 2024
| @@ -77,11 +73,17 @@ public class AnimatedImageViewWrapper : PlatformView { | |||
| public override init(frame frameRect: CGRect) { | |||
| super.init(frame: frameRect) | |||
| addSubview(wrapped) | |||
| observation = observe(\.wrapped.image, options: [.new]) { observe, change in | |||
| self.invalidateIntrinsicContentSize() | |||
There was a problem hiding this comment.
Have to use KVO to get notified when subview's content changes...No better idea
There was a problem hiding this comment.
Use _, _ instead
…ge for AnimatedImage
dreampiggy
force-pushed
the
bugfix/transition_animatedImage
branch
from
d7c7639
to
d68c13a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This close the issue during the changes of #324
Also, the
WebImageshould use thatTransactionduring the image loading status changed