ci: define env variables directly in workflow

SE-UUlm · Dec 10, 2024 · 26953a2 · 26953a2
1 parent 29cf044
commit 26953a2
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 17 deletions.
diff --git a/.github/workflows/code_quality_checks.yml b/.github/workflows/code_quality_checks.yml
@@ -10,6 +10,7 @@ on:
 
 env:
     node_version: ${{ vars.NODE_VERSION }}
+    PUBLIC_API_BASE_URL: http://localhost:8080
 
 jobs:
     linting:
@@ -45,9 +46,6 @@ jobs:
             - name: Install dependencies
               run: npm install
 
-            - name: Create .env file from .env.example
-              run: cat .env.example > .env
-
             - name: Run unit tests
               run: npm run test:unit
 
@@ -75,9 +73,6 @@ jobs:
             - name: Install dependencies
               run: npm install
 
-            - name: Create .env file from .env.example
-              run: cat .env.example > .env
-
             - name: Run integration tests
               run: npm run test:integration
 
@@ -106,9 +101,6 @@ jobs:
             - name: Install dependencies
               run: npm install
 
-            - name: Create .env file from .env.example
-              run: cat .env.example > .env
-
             - name: Install Playwright
               run: npx playwright install --with-deps
 
@@ -190,8 +182,5 @@ jobs:
             - name: Install dependencies
               run: npm install
 
-            - name: Create .env file from .env.example
-              run: cat .env.example > .env
-
             - name: Run all checks
               run: npm run check
diff --git a/.github/workflows/lighthouse.yml b/.github/workflows/lighthouse.yml
@@ -5,6 +5,10 @@ on:
         types:
             - review_requested
 
+env:
+    node_version: ${{ vars.NODE_VERSION }}
+    PUBLIC_API_BASE_URL: http://localhost:8080
+
 jobs:
     lighthouse:
         name: Lighthouse Auditing
@@ -21,9 +25,6 @@ jobs:
             - name: Install dependencies
               run: npm install
 
-            - name: Create .env file from .env.example
-              run: cat .env.example > .env
-
             - name: Build application
               run: npm run build
 

diff --git a/src/lib/backend-api.ts b/src/lib/backend-api.ts
@@ -90,7 +90,7 @@ export interface IAuthorController {
 }
 
 export interface IBackendController {
-    signIn(username: string, password: string): Promise<User>;
+    signIn(email: string, password: string): Promise<User>;
     signOut(): Promise<void>;
     requestEmailForgottenPassword(email: string): Promise<void>;
 

diff --git a/src/lib/controller/backend-controller.ts b/src/lib/controller/backend-controller.ts
@@ -34,7 +34,7 @@ export class BackendController implements IBackendController {
     }
 
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    async signIn(username: string, password: string): Promise<User> {
+    async signIn(email: string, password: string): Promise<User> {
         throw new Error("Method not implemented.");
     }