Skip to content

Commit

Permalink
ci: replace hard coded env variable with variable from github
Browse files Browse the repository at this point in the history
This way, we can control the value at one place
  • Loading branch information
Slartibartfass2 committed Dec 17, 2024
1 parent 6f6ab1f commit cf58001
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
@@ -9,7 +9,7 @@ on:

env:
node_version: ${{ vars.NODE_VERSION }}
PUBLIC_API_BASE_URL: http://localhost:8080
PUBLIC_API_BASE_URL: ${{ vars.PUBLIC_API_BASE_URL }}

jobs:
build:
2 changes: 1 addition & 1 deletion .github/workflows/code_quality_checks.yml
Original file line number Diff line number Diff line change
@@ -10,7 +10,7 @@ on:

env:
node_version: ${{ vars.NODE_VERSION }}
PUBLIC_API_BASE_URL: http://localhost:8080
PUBLIC_API_BASE_URL: ${{ vars.PUBLIC_API_BASE_URL }}

jobs:
linting:
2 changes: 1 addition & 1 deletion .github/workflows/lighthouse.yml
Original file line number Diff line number Diff line change
@@ -7,7 +7,7 @@ on:

env:
node_version: ${{ vars.NODE_VERSION }}
PUBLIC_API_BASE_URL: http://localhost:8080
PUBLIC_API_BASE_URL: ${{ vars.PUBLIC_API_BASE_URL }}

jobs:
lighthouse:

0 comments on commit cf58001

Please sign in to comment.