Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show projects list on homepage #122

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from

Conversation

Merseleo
Copy link
Contributor

@Merseleo Merseleo commented Dec 4, 2024

Closes #6

Hint: For properly testing the new homepage, you need to either run the mock backend server (and checkout feat/add-demo-projects) or do load the data from the server, but statically in the load function (in +page.ts) from the homepage.

What I have made

  • added basic layout to the Homepage (with Todo for "Open Reviews" list, see [Use Case]: View Open Reviews #121)

  • added component for project list entry, which can navigate to the project dashboard on click and display project metadata

  • added component for named list, which get an array of list items and display the list in a uniform layout

    • the list expects a component as child, in which a entry from the item list can be wrapped (as well as the corresponding skeleton component)
  • from now on the primitive components are not considered in test coverage anymore, although they would probably have 100% coverage when used in composite components

Checklist

Either tick or cross out the items that do not apply (using ~~example text~~) and give a reason why the item does not apply.

  • I have updated the documentation accordingly and commented my code
  • I have added tests that prove my fix is effective or that my feature works
    • [ ] unit tests (this PR adds two components and their usage, so there are no separate units that need to be tested, but only the components which are tested using integration tests)
    • integration tests
    • [ ] end-to-end tests (not possible yet)
  • (for reviewer) I have checked the implementation against the requirements

@Merseleo Merseleo linked an issue Dec 4, 2024 that may be closed by this pull request
@Merseleo Merseleo self-assigned this Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

LCOV of commit 4147902 during Code Quality Checks #342

Summary coverage rate:
  lines......: 50.9% (322 of 632 lines)
  functions..: 16.4% (11 of 67 functions)
  branches...: no data found

Files changed coverage rate:
                                                                                  |Lines       |Functions  |Branches    
  Filename                                                                        |Rate     Num|Rate    Num|Rate     Num
  ======================================================================================================================
  src/lib/components/composites/project-components/ProjectListEntry.svelte        | 0.0%      7| 0.0%     1|    -      0
  src/lib/components/composites/project-components/ProjectListEntrySkeleton.svelte| 0.0%      2| 0.0%     1|    -      0
  src/lib/components/composites/utils/NamedList.svelte                            | 0.0%     12| 0.0%     1|    -      0
  src/lib/components/primitives/progress/index.ts                                 | 0.0%      1| 0.0%     1|    -      0
  src/lib/components/primitives/progress/progress.svelte                          | 0.0%      7| 0.0%     1|    -      0
  src/lib/components/primitives/skeleton/index.ts                                 | 0.0%      1| 0.0%     1|    -      0
  src/lib/components/primitives/skeleton/skeleton.svelte                          | 0.0%      6| 0.0%     1|    -      0
  src/lib/controller/backend-controller.ts                                        | 0.0%     59| 0.0%     1|    -      0
  src/lib/controller/project-controller.ts                                        | 0.0%     60| 0.0%     1|    -      0
  src/lib/controller/stage-controller.ts                                          | 0.0%     27| 0.0%     1|    -      0
  src/lib/controller/user-controller.ts                                           | 0.0%     37| 0.0%     1|    -      0
  src/lib/model/backend.ts                                                        | 100%      8| 0.0%     1|    -      0

@Merseleo Merseleo force-pushed the feat/6-use-case-view-project-list branch 2 times, most recently from 2350c56 to 3b66604 Compare December 10, 2024 18:04
@Merseleo Merseleo marked this pull request as ready for review December 16, 2024 23:35
@Merseleo Merseleo force-pushed the feat/6-use-case-view-project-list branch from ed307fc to b50f323 Compare December 17, 2024 12:16
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure about this? We will have to adjust the import for every new component?
What about adjusting the components.json to have a separate shadcn utils directory?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Use Case]: View Project List
2 participants