-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show projects list on homepage #122
Open
Merseleo
wants to merge
11
commits into
develop
Choose a base branch
from
feat/6-use-case-view-project-list
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LCOV of commit
|
Merseleo
force-pushed
the
feat/6-use-case-view-project-list
branch
2 times, most recently
from
December 10, 2024 18:04
2350c56
to
3b66604
Compare
…r component, used on the homepage)"
… for the homepage to create a demo project
… render a list of custom list items and created demo entries, displayed on the homepage
…in format: 'yourListname (<number of li>)'
…ing dummy projects (currently problems with APIs)
…ing dummy projects (currently problems with APIs)
…ulateStageProgress method to unit test it)
Merseleo
force-pushed
the
feat/6-use-case-view-project-list
branch
from
December 17, 2024 12:16
ed307fc
to
b50f323
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure about this? We will have to adjust the import for every new component?
What about adjusting the components.json
to have a separate shadcn utils directory?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6
What I have made
added basic layout to the Homepage (with Todo for "Open Reviews" list, see [Use Case]: View Open Reviews #121)
added component for project list entry, which can navigate to the project dashboard on click and display project metadata
added component for named list, which get an array of list items and display the list in a uniform layout
from now on the primitive components are not considered in test coverage anymore, although they would probably have 100% coverage when used in composite components
Checklist
Either tick or cross out the items that do not apply (using ~~example text~~) and give a reason why the item does not apply.
[ ] unit tests(this PR adds two components and their usage, so there are no separate units that need to be tested, but only the components which are tested using integration tests)[ ] end-to-end tests(not possible yet)