-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added test reporters and coverage analysis #69
Added test reporters and coverage analysis #69
Conversation
b78ca18
to
eca869e
Compare
LCOV of commit
|
eca869e
to
f02cda4
Compare
8598c89
to
23be779
Compare
33ecf16
to
b001b6e
Compare
c9fb97a
to
1e35733
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again, I think this is a good basis for all the testing and further configuration will follow when writing the tests. However, maybe you could add a meaningful test example, if this is possible (i. e. for a e2e test and a component test, which is probably not possible so far as we don't have any components completed, and normal tests).
And as far as I understood examples etc. correctly the configs look good for now.
One last request: maybe you should add a short section about testing in the Readme.md, so how we test, how to run them locally and what is reported in the CI (optionally). Or do you think differently?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add a real component test in #74, I don't think it makes much sense to add a demo test now.
I'll add a section in the README as soon as we are finished discussing the location of the tests.
340786b
to
c82dabd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are on the right track.
The new section in the README.md surely is helpful for new people and for us at beginning too. But one last question (must not be done in this PR): do you think it is helpful to host the report anywhere and link to them in the README.md or add a coverage badge or something like that?
Now each type of test can be run separately
c82dabd
to
c6c6085
Compare
we could use github pages to host, but I am not convinced that's necessary. If you want to check out the coverage, one could either download the report or just run the tests in the repo. About the coverage badge: Maybe that's possible, but I'm not sure. Perhaps we can research this and add this later. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.