Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added test reporters and coverage analysis #69

Merged

Conversation

Slartibartfass2
Copy link
Contributor

No description provided.

@Slartibartfass2 Slartibartfass2 self-assigned this Nov 10, 2024
@Slartibartfass2 Slartibartfass2 linked an issue Nov 10, 2024 that may be closed by this pull request
@Slartibartfass2 Slartibartfass2 force-pushed the ci/68-feature-add-test-reporters-and-coverage-analysis branch from b78ca18 to eca869e Compare November 10, 2024 01:22
Copy link

github-actions bot commented Nov 10, 2024

LCOV of commit c6c6085 during Code Quality Checks #104

Summary coverage rate:
  lines......: 3.8% (12 of 316 lines)
  functions..: 3.1% (1 of 32 functions)
  branches...: no data found

Files changed coverage rate:
                                                              |Lines       |Functions  |Branches    
  Filename                                                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================================================
  src/lib/components/composites/Demo.svelte                   | 100%     12|50.0%     2|    -      0

@Slartibartfass2 Slartibartfass2 force-pushed the ci/68-feature-add-test-reporters-and-coverage-analysis branch from eca869e to f02cda4 Compare November 10, 2024 01:24
@Slartibartfass2 Slartibartfass2 force-pushed the ci/68-feature-add-test-reporters-and-coverage-analysis branch 2 times, most recently from 8598c89 to 23be779 Compare November 11, 2024 14:42
@Slartibartfass2 Slartibartfass2 force-pushed the ci/68-feature-add-test-reporters-and-coverage-analysis branch 4 times, most recently from c9fb97a to 1e35733 Compare November 14, 2024 23:06
Copy link
Contributor

@Merseleo Merseleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I think this is a good basis for all the testing and further configuration will follow when writing the tests. However, maybe you could add a meaningful test example, if this is possible (i. e. for a e2e test and a component test, which is probably not possible so far as we don't have any components completed, and normal tests).
And as far as I understood examples etc. correctly the configs look good for now.

One last request: maybe you should add a short section about testing in the Readme.md, so how we test, how to run them locally and what is reported in the CI (optionally). Or do you think differently?

.github/semantic.yml Outdated Show resolved Hide resolved
src/app.css Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
e2e/demo.test.ts Outdated Show resolved Hide resolved
vite.config.ts Outdated Show resolved Hide resolved
.github/workflows/code_quality_checks.yml Show resolved Hide resolved
.github/workflows/code_quality_checks.yml Show resolved Hide resolved
@Slartibartfass2 Slartibartfass2 changed the base branch from main to develop November 16, 2024 13:06
Copy link
Contributor Author

@Slartibartfass2 Slartibartfass2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a real component test in #74, I don't think it makes much sense to add a demo test now.

I'll add a section in the README as soon as we are finished discussing the location of the tests.

.github/semantic.yml Outdated Show resolved Hide resolved
vite.config.ts Outdated Show resolved Hide resolved
.github/workflows/code_quality_checks.yml Show resolved Hide resolved
.github/workflows/code_quality_checks.yml Show resolved Hide resolved
src/app.css Outdated Show resolved Hide resolved
e2e/demo.test.ts Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
@Slartibartfass2 Slartibartfass2 requested review from Merseleo and removed request for luca-schlecker November 16, 2024 13:37
@Slartibartfass2 Slartibartfass2 force-pushed the ci/68-feature-add-test-reporters-and-coverage-analysis branch 8 times, most recently from 340786b to c82dabd Compare November 16, 2024 16:57
vite.config.ts Show resolved Hide resolved
.github/workflows/code_quality_checks.yml Show resolved Hide resolved
Merseleo
Merseleo previously approved these changes Nov 16, 2024
Copy link
Contributor

@Merseleo Merseleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are on the right track.
The new section in the README.md surely is helpful for new people and for us at beginning too. But one last question (must not be done in this PR): do you think it is helpful to host the report anywhere and link to them in the README.md or add a coverage badge or something like that?

.github/workflows/code_quality_checks.yml Show resolved Hide resolved
.github/workflows/code_quality_checks.yml Show resolved Hide resolved
.github/workflows/code_quality_checks.yml Show resolved Hide resolved
@Slartibartfass2 Slartibartfass2 force-pushed the ci/68-feature-add-test-reporters-and-coverage-analysis branch from c82dabd to c6c6085 Compare November 16, 2024 19:29
@Slartibartfass2
Copy link
Contributor Author

I think we are on the right track. The new section in the README.md surely is helpful for new people and for us at beginning too. But one last question (must not be done in this PR): do you think it is helpful to host the report anywhere and link to them in the README.md or add a coverage badge or something like that?

we could use github pages to host, but I am not convinced that's necessary. If you want to check out the coverage, one could either download the report or just run the tests in the repo.

About the coverage badge: Maybe that's possible, but I'm not sure. Perhaps we can research this and add this later.

Copy link
Contributor

@Merseleo Merseleo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Merseleo Merseleo merged commit 520c650 into develop Nov 18, 2024
7 checks passed
@Merseleo Merseleo deleted the ci/68-feature-add-test-reporters-and-coverage-analysis branch November 18, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Add test reporters and coverage analysis
2 participants