-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added paper view #89
base: develop
Are you sure you want to change the base?
Added paper view #89
Conversation
LCOV of commit
|
4de9f9f
to
895dbe0
Compare
af5e97c
to
59f9851
Compare
59f9851
to
5139521
Compare
5139521
to
fc5ddfe
Compare
6fabcf3
to
3360d88
Compare
c019ecd
to
f2c89ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! There were some things though that stood out to me. Looking forward to hearing your thoughts on these points.
src/lib/components/composites/paper-components/paper-view/PaperView.svelte
Show resolved
Hide resolved
src/lib/components/composites/paper-components/paper-view/PaperView.svelte
Show resolved
Hide resolved
src/lib/components/composites/paper-components/paper-view/cards/PaperCard.svelte
Show resolved
Hide resolved
src/lib/components/composites/paper-components/paper-view/cards/PaperCard.svelte
Show resolved
Hide resolved
src/lib/components/composites/paper-components/paper-view/cards/PaperResearchContextCard.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the review, I'll rebase when we're finished so that you see the changes I made.
src/lib/components/composites/paper-components/paper-view/PaperView.svelte
Show resolved
Hide resolved
src/lib/components/composites/paper-components/paper-view/PaperView.svelte
Show resolved
Hide resolved
src/lib/components/composites/paper-components/paper-view/cards/PaperCard.svelte
Show resolved
Hide resolved
src/lib/components/composites/paper-components/paper-view/cards/PaperResearchContextCard.svelte
Outdated
Show resolved
Hide resolved
src/lib/components/composites/paper-components/paper-view/cards/PaperCard.svelte
Show resolved
Hide resolved
68832c9
to
8f85015
Compare
It wasn't used anymore.
references/citations to forward/backward references
8f85015
to
11fe5f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. 👍
Closes #34
What I have made
href
prop (like a button would do), this button usesgoto
to navigate to the previous/next paper)goto
method used in the navigation buttonsChecklist
Either tick or cross out the items that do not apply (using ~~example text~~) and give a reason why the item does not apply.
[ ] unit tests(no logic outside of minor component logic was added)[ ] end-to-end tests(we do not have those yet)