Skip to content

Commit

Permalink
Update proguard-rules and build workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
SIKV committed Jun 13, 2024
1 parent a55cd34 commit 74e63d4
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 35 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ jobs:
run: ./gradlew lintDevRelease

- name: Build with Gradle
run: ./gradlew assembleDevReleaseDebuggable -PreleaseKeyAlias='${{ secrets.DEV_KEY_ALIAS }}' -PreleaseKeyPassword='${{ secrets.DEV_KEY_PASSWORD }}' -PreleaseStoreFile='${{ secrets.DEV_KEYSTORE_FILENAME }}' -PreleaseStorePassword='${{ secrets.DEV_KEYSTORE_PASSWORD }}'
run: ./gradlew assembleDevRelease -PreleaseKeyAlias='${{ secrets.DEV_KEY_ALIAS }}' -PreleaseKeyPassword='${{ secrets.DEV_KEY_PASSWORD }}' -PreleaseStoreFile='${{ secrets.DEV_KEYSTORE_FILENAME }}' -PreleaseStorePassword='${{ secrets.DEV_KEYSTORE_PASSWORD }}'

- name: Upload artifact
uses: actions/upload-artifact@v2
Expand Down
5 changes: 0 additions & 5 deletions app/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,6 @@ android {
}
signingConfig = signingConfigs.getByName("release")
}
create("releaseDebuggable") {
initWith(getByName("release"))
matchingFallbacks += "release"
isDebuggable = true
}
create("benchmark") {
initWith(getByName("release"))
signingConfig = signingConfigs.getByName("debug")
Expand Down
31 changes: 7 additions & 24 deletions app/proguard-rules.pro
Original file line number Diff line number Diff line change
@@ -1,27 +1,4 @@
# Add project specific ProGuard rules here.
# You can control the set of applied configuration files using the
# proguardFiles setting in build.gradle.
#
# For more details, see
# http://developer.android.com/guide/developing/tools/proguard.html

# If your project uses WebView with JS, uncomment the following
# and specify the fully qualified class name to the JavaScript interface
# class:
#-keepclassmembers class fqcn.of.javascript.interface.for.webview {
# public *;
#}

# Uncomment this to preserve the line number information for
# debugging stack traces.
#-keepattributes SourceFile,LineNumberTable

# If you keep the line number information, uncomment this to
# hide the original source file name.
#-renamesourcefileattribute SourceFile

# Retrofit

# Retain generic type information for use by reflection by converters and adapters.
-keepattributes Signature
# Retain service method parameters.
Expand All @@ -32,7 +9,6 @@
-dontwarn org.codehaus.mojo.animal_sniffer.IgnoreJRERequirement

# Glide

-keep public class * implements com.bumptech.glide.module.GlideModule
-keep public class * extends com.bumptech.glide.module.AppGlideModule
-keep public enum com.bumptech.glide.load.ImageHeaderParser$** {
Expand All @@ -42,3 +18,10 @@

# Keep model classes
-keep class com.github.sikv.photos.domain.** { *; }

-dontwarn org.bouncycastle.jsse.BCSSLParameters
-dontwarn org.bouncycastle.jsse.BCSSLSocket
-dontwarn org.bouncycastle.jsse.provider.BouncyCastleJsseProvider
-dontwarn org.openjsse.javax.net.ssl.SSLParameters
-dontwarn org.openjsse.javax.net.ssl.SSLSocket
-dontwarn org.openjsse.net.ssl.OpenJSSE
5 changes: 0 additions & 5 deletions app/src/androidTest/java/com/github/sikv/photos/Utils.kt

This file was deleted.

0 comments on commit 74e63d4

Please sign in to comment.