Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Firebird test reference correct database #1099

Closed
wants to merge 1 commit into from

Conversation

Krzmbrzl
Copy link
Contributor

@Krzmbrzl Krzmbrzl commented Oct 24, 2023

In the CI, a database called soci_test is created

echo 'CREATE DATABASE "LOCALHOST:/tmp/soci_test.fdb" PAGE_SIZE = 16384;' > /tmp/create_soci_test.sql

but the CMakeLists.txt for the Firebird test encoded a database name of test. Somehow this still worked on the CI, but it didn't work for me locally (invoking ctest directly).
Furthermore, using soci_test as the table name makes things more consistent with the tests for other backends.

@vadz vadz added the Firebird label Nov 11, 2023
@vadz
Copy link
Member

vadz commented Nov 11, 2023

I really don't understand how did it work before neither, could we be creating test.fdb somewhere else?

@Krzmbrzl
Copy link
Contributor Author

Maybe the connection string is modified on the CI via some sort of environment variable or something like that?

vadz pushed a commit that referenced this pull request Dec 11, 2023
@vadz
Copy link
Member

vadz commented Dec 11, 2023

Thanks for fixing this, finally merged.

@vadz vadz closed this Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants