Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GPU version of interface-discontinuity-based wavefield injection (pull request 1706). #1779

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

tianshi-liu
Copy link

The script to run the small example is also updated to use the GPU version. Currently only forward simulation; adjoint simulation and kernel calculation will come soon.

Copy link

codecov bot commented Jan 3, 2025

Codecov Report

Attention: Patch coverage is 15.62500% with 27 lines in your changes missing coverage. Please review.

Project coverage is 49.75%. Comparing base (0fb684c) to head (0e8cbe3).
Report is 4 commits behind head on devel.

Files with missing lines Patch % Lines
src/specfem3D/wavefield_discontinuity_solver.f90 21.42% 11 Missing ⚠️
src/gpu/specfem3D_gpu_cuda_method_stubs.c 0.00% 6 Missing ⚠️
...3D/compute_forces_viscoelastic_calling_routine.F90 0.00% 5 Missing ⚠️
src/specfem3D/prepare_gpu.f90 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            devel    #1779      +/-   ##
==========================================
- Coverage   49.77%   49.75%   -0.02%     
==========================================
  Files         272      272              
  Lines       62879    62903      +24     
==========================================
+ Hits        31296    31299       +3     
- Misses      31583    31604      +21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tianshi-liu
Copy link
Author

I got an error during "test intel on ubuntu-22.04", and it looks like it's due to compilation error at line 797 of src/shared/read_parameter_file.f90. I couldn't understand the error so far, and no changes have been made near that line (the only change to this file is at line 1079. If I could get some help on what is potentially going wrong that would be great! Thanks!

@danielpeter
Copy link
Member

no worries, the error seems to be some internal compiler hiccup with the Intel compiler (happening from time to time).

thanks a lot for the GPU support :)

@danielpeter danielpeter merged commit a8182ff into SPECFEM:devel Jan 6, 2025
41 of 43 checks passed
@tianshi-liu
Copy link
Author

Great! Thanks a lot for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants