Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LAB2] 312551080 #122

Merged
merged 2 commits into from
Mar 20, 2024
Merged

[LAB2] 312551080 #122

merged 2 commits into from
Mar 20, 2024

Conversation

hsuanyu414
Copy link

Description

LAB2 finish with 100% coverage

  • A clear title (name your PR "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing all CI (You should check it first to pass one of the validations in CI. However, you need to make sure your PR passes all CI after you submit it.)

@TaiYou-TW TaiYou-TW added the lab2 label Mar 11, 2024
@hsuanyu414
udpate lab2
ca6ed4c 
1. adding spy
2. editing comment
3. editing variable name
@AlaRduTP AlaRduTP merged commit e7f7984 into SQLab:312551080 Mar 20, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lab2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hsuanyu414 @TaiYou-TW @AlaRduTP