Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LAB2] 312552020 #134

Merged
merged 8 commits into from
Mar 20, 2024
Merged

[LAB2] 312552020 #134

merged 8 commits into from
Mar 20, 2024

Conversation

martintl25
Copy link

Description

Update: Complete the code in main_test.js for testing main.js.

main_test.js implements a single testing function for each method defined in MailSystem and Application. As being initialized, an Application instance would create a MailSystem object as its class member.

Here is a list of the methods of 2 classes:

  1. MailSystem.write(string)
  2. MailSystem.send(string, string)
  3. Application.getNames()
  4. Application.getRandomPerson()
  5. Application.selectNextPerson()
  6. Application.notifySelected()

  • A clear title (name your PR "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing all CI (You should check it first to pass one of the validations in CI. However, you need to make sure your PR passes all CI after you submit it.)

@TaiYou-TW TaiYou-TW added the lab2 label Mar 12, 2024
@martintl25 martintl25 closed this Mar 12, 2024
@TaiYou-TW TaiYou-TW reopened this Mar 12, 2024
@TaiYou-TW TaiYou-TW force-pushed the 312552020 branch 3 times, most recently from c93aa51 to 42eded5 Compare March 12, 2024 14:31
@TaiYou-TW
Copy link
Contributor

This PR looks okay for merge and grading.

@AlaRduTP AlaRduTP merged commit 0e2c3cd into SQLab:312552020 Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants