Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LAB2] 310552064 #143

Merged
merged 14 commits into from
Mar 20, 2024
Merged

[LAB2] 310552064 #143

merged 14 commits into from
Mar 20, 2024

Conversation

veture7275
Copy link

@veture7275 veture7275 commented Mar 13, 2024

write tests for each function and use mock in MailSystem-send

  • A clear title (name your PR "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing all CI (You should check it first to pass one of the validations in CI. However, you need to make sure your PR passes all CI after you submit it.)

@TaiYou-TW TaiYou-TW added the lab2 label Mar 13, 2024
@AlaRduTP AlaRduTP merged commit c61009d into SQLab:310552064 Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants