Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lab1] 312551098 #38

Merged
merged 3 commits into from
Mar 7, 2024
Merged

[Lab1] 312551098 #38

merged 3 commits into from
Mar 7, 2024

Conversation

EusdenLin
Copy link

@EusdenLin EusdenLin commented Feb 29, 2024 •
edited
Loading

Description

Add test cases in main_test.js, validated with validate.sh.

  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@TaiYou-TW TaiYou-TW closed this Feb 29, 2024
@TaiYou-TW TaiYou-TW reopened this Feb 29, 2024
@TaiYou-TW TaiYou-TW added the lab1 label Feb 29, 2024
@TaiYou-TW TaiYou-TW merged commit dec05be into SQLab:312551098 Mar 7, 2024
5 checks passed
@TaiYou-TW
Copy link
Contributor

Remember to follow PR title's rule next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lab1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EusdenLin @TaiYou-TW