Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LAB1] 312551078 #46

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[LAB1] 312551078 #46

merged 1 commit into from
Mar 7, 2024

Conversation

linhengpei
Copy link

Description

#2


  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@TaiYou-TW TaiYou-TW added the lab1 label Feb 29, 2024
Comment on lines +25 to +28
student.setName("John"); // 使用assert.strictEqual来断言student的name属性是否被正确设置
assert.strictEqual(student.name, "John");

student.setName(123); // 尝试使用非字符串值设置
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those comments and code written on your own? If it's copied or generated from somewhere else, it's okay. But I hope you can understand and encourage you to write them by yourself.

@TaiYou-TW TaiYou-TW merged commit 262ce78 into SQLab:312551078 Mar 7, 2024
2 checks passed
@TaiYou-TW
Copy link
Contributor

Please also leave meaningful messages on your commits next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants