Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LAB1]312551004 #50

Merged
merged 1 commit into from
Mar 7, 2024
Merged

[LAB1]312551004 #50

merged 1 commit into from
Mar 7, 2024

Conversation

SUNGOD3
Copy link

@SUNGOD3 SUNGOD3 commented Mar 1, 2024

Description

#2

  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@TaiYou-TW TaiYou-TW added the lab1 label Mar 1, 2024
@SUNGOD3 SUNGOD3 changed the title [lab1]312551004 [LAB1]312551004 Mar 1, 2024
@TaiYou-TW
Copy link
Contributor

TaiYou-TW commented Mar 7, 2024 •
edited
Loading

Your base branch can't be main. Please remember to develop on your own branch next time.
Also, your PR title format is wrong.

@TaiYou-TW TaiYou-TW merged commit 618221d into SQLab:312551004 Mar 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
lab1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SUNGOD3 @TaiYou-TW