Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LAB1] 312552024 #52

Merged
merged 4 commits into from
Mar 7, 2024
Merged

[LAB1] 312552024 #52

merged 4 commits into from
Mar 7, 2024

Conversation

cherry900606
Copy link

Description

  1. Add test in main_test.js
  2. Achieve 100% code coverage

(Note: 上一次的 pull request 因操作錯誤 coverage 沒到 100% 故重新上傳)


  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@TaiYou-TW TaiYou-TW added the lab1 label Mar 1, 2024
@TaiYou-TW
Copy link
Contributor

You don't need to close the old one and open a new one. The updated code will appear here when you push your code to your repo.

@TaiYou-TW TaiYou-TW merged commit 204cc0d into SQLab:312552024 Mar 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants