[LAB7] 311552005

.github/workflows/PR.yml

@@ -15,27 +15,31 @@ jobs:
                       const { owner, repo, number: issue_number } = context.issue;
                       const pr = await github.rest.pulls.get({ owner, repo, pull_number: issue_number });
                       const title = pr.data.title;
-                      const labRegex = /\[LAB(\d+)\]/;
-                      const titleRegex = /^\[LAB\d+\] [\da-zA-Z]+$/;
 
-                      if (!titleRegex.test(title)) {
-                        core.setFailed('PR title does not match the required format. Please use the format [LAB#] student#.');
+                      const titleRegex = /^\[LAB(\d+)\] [a-zA-Z]?\d+$/;
+                      const match = title.match(titleRegex);
+
+                      let labNumberStr = undefined;
+                      if (match) {
+                        labNumberStr = match[1];
+                      } else {
+                        core.setFailed('PR title does not match the required format. Please use the format: [LAB#] <studentId>.');
                       }
 
-                      if (pr.data.head.ref !== pr.data.base.ref) {
-                        core.setFailed('The source branch and target branch must be the same.');
+                      const labelToAdd = `lab${labNumberStr}`;
+                      if (labNumberStr) {
+                        await github.rest.issues.addLabels({ owner, repo, issue_number, labels: [labelToAdd] });
                       }
 
                       if (pr.data.base.ref === 'main') {
                         core.setFailed('The target branch cannot be main.');
                       }
 
-                      const match = title.match(labRegex);
-                      if (match) {
-                        const labelToAdd = 'lab' + match[1];
-                        await github.rest.issues.addLabels({ owner, repo, issue_number, labels: [labelToAdd] });
-                      } else {
-                        core.setFailed('No match found in PR title. Please add a label in the format [LAB#] to the PR title.');
+                      if (labNumberStr < 3 && pr.data.head.ref !== pr.data.base.ref) {
+                        core.setFailed('The source branch and target branch must be the same.');
+                      }
+                      if (labNumberStr >= 3 && pr.data.head.ref !== labelToAdd) {
+                        core.setFailed(`The source branch must be '${labelToAdd}'`);
                       }
     checklist-check:
         runs-on: ubuntu-latest
@@ -49,12 +53,12 @@ jobs:
                       const pr = await github.rest.pulls.get({ owner, repo, pull_number: issue_number });
                       const body = pr.data.body;
 
-                      const checkboxes = body.match(/\- \[[x ]\]/g);
+                      const checkboxes = body.match(/^ ?(-|\*) \[[x ]\]/gmi);
                       if (!checkboxes || checkboxes.length !== 5) {
                         core.setFailed('The PR description must contain exactly 5 checkboxes.');
                       }
 
-                      const unchecked = body.match(/\- \[ \]/g);
+                      const unchecked = body.match(/^ ?(-|\*) \[ \]/gm);
                       if (unchecked && unchecked.length > 0) {
-                        core.setFailed(`There are ${unchecked.length} unchecked items in the PR description.`);
+                        core.setFailed(`There are ${unchecked.length} unchecked item(s) in the PR description.`);
                       }

.github/workflows/lab-autograding.yml

@@ -0,0 +1,56 @@
+name: Autograding
+
+on:
+    pull_request_target:
+        types: [labeled, synchronize, opened, reopened, ready_for_review]
+
+jobs:
+    build:
+        runs-on: ${{ matrix.os }}
+        strategy:
+            matrix:
+                os: [ubuntu-22.04]
+            fail-fast: false
+        steps:
+            - uses: actions/checkout@v4
+              with:
+                  ref: "${{ github.event.pull_request.merge_commit_sha }}"
+                  fetch-depth: 1
+            - uses: actions/setup-node@v4
+              with:
+                  node-version: latest
+            - name: Extract lab number and Check no changes other than specific files
+              uses: actions/github-script@v5
+              id: lab
+              with:
+                  result-encoding: string
+                  github-token: ${{ secrets.GITHUB_TOKEN }}
+                  script: |
+                      const { owner, repo, number: issue_number } = context.issue;
+                      const pr = await github.rest.pulls.get({ owner, repo, pull_number: issue_number });
+                      const labels = pr.data.labels;
+                      const lab = labels.find((label) => label.name.startsWith('lab'));
+                      if (!lab) {
+                        core.setFailed('No lab label found on the PR.');
+                        return { number: 0 };
+                      }
+                      const labNumberMatch = lab.name.match(/lab(\d+)/);
+                      if (!labNumberMatch) {
+                        core.setFailed('Invalid lab label found on the PR.');
+                        return { number: 0 };
+                      }
+                      const labNumber = labNumberMatch[1];
+                      console.log(`Lab number: ${labNumber}`)
+
+                      const files = await github.rest.pulls.listFiles({ owner, repo, pull_number: issue_number });
+                      const changedFiles = files.data.map((file) => file.filename);
+                      const allowedFileRegex = /^lab\d+\/main_test.js$/;
+                      const specialChangedFiles = ["lab5/Answer.md", "lab5/antiasan.c", "lab6/Answer.md", "lab7/sol.py"];
+                      if (!changedFiles.every((file) => (allowedFileRegex.test(file) || specialChangedFiles.includes(file)))) {
+                        core.setFailed('The PR contains changes to files other than the allowed files.');
+                      }
+                      return labNumber;
+            - name: Grading
+              run: |
+                  cd lab${{ steps.lab.outputs.result }}
+                  ./validate.sh

.gitignore

@@ -0,0 +1 @@
+node_modules/

lab1/main_test.js

@@ -3,21 +3,54 @@ const assert = require('assert');
 const { MyClass, Student } = require('./main');
 
 test("Test MyClass's addStudent", () => {
-    // TODO
-    throw new Error("Test not implemented");
+
+    //case 1
+    const myclass = new MyClass();
+    assert.strictEqual(myclass.addStudent("for_test"), -1);
+
+    //case 2
+    const student = new Student();
+    assert.strictEqual(myclass.addStudent(student), 0);
+
 });
 
 test("Test MyClass's getStudentById", () => {
-    // TODO
-    throw new Error("Test not implemented");
+
+    //case 1
+    const myclass = new MyClass();
+    assert.strictEqual(myclass.getStudentById(-1), null);
+
+    //case 2
+    assert.strictEqual(myclass.getStudentById(1),null);
+
+    //case 3
+    const student1 = new Student();
+    myclass.addStudent(student1);
+    assert.strictEqual(myclass.getStudentById(0),student1);
+
 });
 
 test("Test Student's setName", () => {
-    // TODO
-    throw new Error("Test not implemented");
+
+    const student = new Student();
+
+     //case 1
+    assert.strictEqual(student.setName(1), undefined);
+
+     //case 2
+    assert.strictEqual(student.setName('Amy'), undefined);
+
 });
 
 test("Test Student's getName", () => {
-    // TODO
-    throw new Error("Test not implemented");
-});
+
+    const student = new Student();
+
+    //case 1
+    assert.strictEqual(student.getName(),'');
+
+    //case 2
+    student.setName('Amy');
+    assert.strictEqual(student.getName(),'Amy');
+
+});

lab2/main_test.js

@@ -1,6 +1,104 @@
 const test = require('node:test');
 const assert = require('assert');
+const fs = require('fs');
+
+test.mock.method(fs, "readFile", (path, encoding, callback) => {
+    callback(null, "Amy\nJack");
+});
+
+const names = ['Amy', 'Jack'];
 const { Application, MailSystem } = require('./main');
 
-// TODO: write your tests here
-// Remember to use Stub, Mock, and Spy when necessary
+test("Test MailSystem's write", () => {
+
+    const mailSystem = new MailSystem();
+    assert.strictEqual(mailSystem.write(names[0]), 'Congrats, ' + names[0] + '!');
+
+});
+
+test("Test MailSystem's send", () => {
+
+    const mailSystem = new MailSystem();
+
+    //case 1
+    test.mock.method(Math, "random", () => true);
+    for(let i = 0; i < names.length; i++) {
+        assert.strictEqual(mailSystem.send(names[i]), true);
+    }
+
+    //case 2
+    test.mock.method(Math, "random", () => false);
+    for(let i = 0; i < names.length; i++) {
+        assert.strictEqual(mailSystem.send(names[i]), false);
+    }
+
+});
+
+test("Test Application's getNames", async () => {
+
+    const application = new Application();
+    application.people = names;
+    const [people, selected] = await application.getNames();
+    assert.deepStrictEqual(people, names);
+    assert.deepStrictEqual(selected, []);
+
+});
+
+test("Test Application's getRandomPerson", () => {
+
+    const application = new Application();
+    application.people = names;
+
+    for(let i = 0; i < names.length; i++) {
+        test.mock.method(Math, "floor", () => i);
+        assert.strictEqual(application.getRandomPerson(), names[i]);
+    }
+
+});
+
+test("Test Application's selectNextPerson", async () => {
+
+    const application = new Application();
+    application.people = names;
+
+    application.getRandomPerson = () => "Amy";
+    assert.strictEqual(application.selectNextPerson(),'Amy');
+    assert.deepStrictEqual(application.selected,["Amy"]);
+
+    let count = 1;
+    application.getRandomPerson = () => {
+        if (count % 2){
+            count++;
+            return "Amy";
+        }
+        return "Jack";
+    };
+    assert.strictEqual(application.selectNextPerson(),'Jack');
+    assert.deepStrictEqual(application.selected,["Amy","Jack"]);
+
+    assert.strictEqual(application.selectNextPerson(),null);
+
+});
+
+test("Test Application's notifySelected", () => {
+
+    const application = new Application();
+
+    application.mailSystem.write = test.mock.fn(application.mailSystem.write);
+    application.mailSystem.send = test.mock.fn(() => true);
+
+    application.selected = names;
+    application.notifySelected();
+
+
+    //check call arguments
+    assert.strictEqual(application.mailSystem.write.mock.calls[0].arguments[0], names[0]);
+    assert.strictEqual(application.mailSystem.send.mock.calls[0].arguments[0], names[0]);
+    assert.strictEqual(application.mailSystem.write.mock.calls[1].arguments[0], names[1]);
+    assert.strictEqual(application.mailSystem.send.mock.calls[1].arguments[0], names[1]);
+
+    // //check call times
+    assert.strictEqual(application.mailSystem.write.mock.calls.length, names.length);
+    assert.strictEqual(application.mailSystem.send.mock.calls.length, names.length);  
+
+});

lab3/README.md

@@ -0,0 +1,29 @@
+# Lab3
+
+## Introduction
+
+In this lab, you will write unit tests for functions implemented in `main.js`. You can learn how to use classes and functions in it by uncommenting the code in it. (But remember don't commit them on GitHub)
+
+## Preparation (Important!!!)
+
+1. Sync fork on GitHub
+2. `git checkout -b lab3` (**NOT** your student ID !!!)
+
+## Requirement
+
+1. (40%) Write test cases in `main_test.js` and achieve 100% code coverage.
+2. (30%) For each function, parameterize their testcases to test the error-results.
+3. (30%) For each function, use at least 3 parameterized testcases to test the non-error-results.
+
+You can run `validate.sh` in your local to test if you satisfy the requirements.
+
+Please note that you must not alter files other than `main_test.js`. You will get 0 points if
+
+1. you modify other files to achieve requirements.
+2. you can't pass all CI on your PR.
+
+## Submission
+
+You need to open a pull request to your branch (e.g. 311XXXXXX, your student number) and contain the code that satisfies the abovementioned requirements.
+
+Moreover, please submit the URL of your PR to E3. Your submission will only be accepted when you present at both places.