Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LAB1] 312551011 #66

Merged
merged 1 commit into from
Mar 10, 2024
Merged

[LAB1] 312551011 #66

merged 1 commit into from
Mar 10, 2024

Conversation

YJack0000
Copy link

@YJack0000 YJack0000 commented Mar 4, 2024 •
edited
Loading

Description

#2

  • test: finish test of main.js
  • A clear title (name your pr "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing tests/CI

@YJack0000 YJack0000 changed the title feat: finish test of main.js [LAB1] 312551011 Mar 4, 2024
@TaiYou-TW TaiYou-TW added the lab1 label Mar 4, 2024
@TaiYou-TW
Copy link
Contributor

You need to use correct base branch next time.

@TaiYou-TW TaiYou-TW merged commit 3e201ed into SQLab:312551011 Mar 10, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@YJack0000 YJack0000

Labels
lab1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YJack0000 @TaiYou-TW