Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LAB2] 312551098 #88

Closed
wants to merge 15 commits into from
Closed

[LAB2] 312551098 #88

wants to merge 15 commits into from

Conversation

EusdenLin
Copy link

Description

At lab2, I write the main_test.js for the two main classes: mailsystem and application.
For mailsystem, I stub the mailsystem with a fake name and fake context to test the send/write functions.
For application, I create a fake name_list.txt for the getNames() function.
Check if the selected people are from the name list, the initialization about the application.
Finally, I mocked the send/write function in the mailsystem, making sure the notifySelected() function calls the selected people in the correct order and has no redundant calls.


  • A clear title (name your PR "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing all CI (You should check it first to pass one of the validations in CI. However, you need to make sure your PR passes all CI after you submit it.)

@TaiYou-TW TaiYou-TW added the lab2 label Mar 8, 2024
@EusdenLin EusdenLin reopened this Mar 24, 2024
@EusdenLin EusdenLin closed this Mar 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants