Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LAB1] 311552005 #91

Merged
merged 1 commit into from
Mar 8, 2024
Merged

[LAB1] 311552005 #91

merged 1 commit into from
Mar 8, 2024

Conversation

patty5531998
Copy link

@patty5531998 patty5531998 commented Mar 8, 2024

Description

Update main_test.js and finish Lab1


  • A clear title (name your PR "[LAB{lab_number}] {your_student_id}")
  • A meaningful message for PR, as well as its commits
  • From your specific branch (not main or other's branch) merging to your branch
  • Excluding any irrelevant files, such as binaries, text files, or dot files
  • Passing all CI (You should check it first to pass one of the validations in CI. However, you need to make sure your PR passes all CI after you submit it.)

@TaiYou-TW TaiYou-TW added the lab1 label Mar 8, 2024
@TaiYou-TW
Copy link
Contributor

TaiYou-TW commented Mar 8, 2024

You should not only validate return value but also the side-effect. For instance, you should validate the object's variable as well.
You can look at https://github.com/SQLab/112-spring-software-testing/pull/90/files#diff-34815f5f09f6d4f80b9587c2f3f7c449454027de3fe5b63658697a8fd009a339R45-R50

@TaiYou-TW TaiYou-TW merged commit cfe2098 into SQLab:311552005 Mar 8, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants