Updated ADC Implementation to support ESP-IDF 5.0 #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperChamp234
force-pushed
the
adc-impl-5.0
branch
from
4ac11f3
to
6bcd937
Compare
RISHI27-dot
reviewed
Jan 17, 2024
RISHI27-dot
reviewed
Jan 17, 2024
RISHI27-dot
reviewed
Jan 17, 2024
RISHI27-dot
reviewed
Jan 17, 2024
RISHI27-dot
reviewed
Jan 17, 2024
RISHI27-dot
reviewed
Jan 17, 2024
RISHI27-dot
reviewed
Jan 17, 2024
RISHI27-dot
reviewed
Jan 17, 2024
RISHI27-dot
reviewed
Jan 17, 2024
RISHI27-dot
reviewed
Jan 17, 2024
SuperChamp234
added a commit
to SuperChamp234/sra-board-component
that referenced
this pull request
Jan 28, 2024
|
Hi @RISHI27-dot , |
SuperChamp234
added a commit
to SuperChamp234/sra-board-component
that referenced
this pull request
Jan 30, 2024
SuperChamp234
force-pushed
the
adc-impl-5.0
branch
from
1f23db2
to
1f7046c
Compare
RISHI27-dot
reviewed
Jan 30, 2024
RISHI27-dot
reviewed
Feb 1, 2024
…C Read impl remaining. Completed ADC Read method implementation Changed ADC Bitwidth to 12, and removed extra config files while adding gitignore rules for them. Updated LSA example
SuperChamp234
force-pushed
the
adc-impl-5.0
branch
from
1f7046c
to
d0f41cc
Compare
RISHI27-dot
reviewed
Feb 1, 2024
RISHI27-dot
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am issuing this PR to update our ADC Implementation for ESP-IDF 5.0.
As per pull request #87 , I have rewritten the ADC implementation to use methods from the new ESP-IDF 5.0 library.
It makes use of the
esp_adccomponent instead of the depreciatedesp_adc_cal.The new ADC methods require the use of an
adc_handle_twhen trying to access the ADC object and perform actions.Please review and let me know the changes, thank you.