MCPWM Implementation update for ESP-IDF 5.0 #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperChamp234
force-pushed
the
mcpwm-impl-5.0
branch
from
c5c8f0c
to
3b65cd2
Compare
RISHI27-dot
reviewed
Jan 30, 2024
RISHI27-dot
reviewed
Jan 30, 2024
RISHI27-dot
reviewed
Jan 30, 2024
RISHI27-dot
reviewed
Jan 30, 2024
RISHI27-dot
reviewed
Jan 30, 2024
RISHI27-dot
reviewed
Jan 30, 2024
VedantParanjape
requested changes
Jan 30, 2024
SuperChamp234
force-pushed
the
mcpwm-impl-5.0
branch
from
3b65cd2
to
329a81c
Compare
RISHI27-dot
reviewed
Jan 31, 2024
RISHI27-dot
reviewed
Jan 31, 2024
RISHI27-dot
reviewed
Jan 31, 2024
RISHI27-dot
reviewed
Jan 31, 2024
Updated MCPWM Interface, but stuck at an exception ( Guru Meditation Error: Core 0 panic'ed (InstrFetchError). Updated small pointer error. Fixed double pointer assignment error. Cleaned Interface, fixed issue with mapping of duty cycle values Fixed silly error in pindefs for motors motor driver parallel example deleted Small change in include files
Delete .vscode directory Uncommented out code and add license headers to header files Add .gitignore entry for sdkconfig file
SuperChamp234
force-pushed
the
mcpwm-impl-5.0
branch
from
1e043c2
to
0fb2c89
Compare
RISHI27-dot
requested changes
Jan 31, 2024
SuperChamp234
force-pushed
the
mcpwm-impl-5.0
branch
from
ff5df4a
to
c5e30ab
Compare
RISHI27-dot
approved these changes
Jan 31, 2024
There was a problem hiding this comment.
@VedantParanjape The Wall-E bot successfully achieves self-balancing through the implemented MCPWM driver, and I have completed my review. Please add your reviews so that we can proceed with merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am issuing this PR to update the MCPWM implementation for ESP-IDF 5.0.
As per pull request #88 , I have rewritten the MCPWM implementation for ESP-IDF 5.0. It make use of the
driver/mcpwm_prelude.hnow.This new MCPWM implementation requires the use of a
motor_handle_twhen trying to access the mcpwm object and perform actions.Please review and let me know the changes, thank you.