Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

118 code review feedback luke parker #127

Merged
merged 23 commits into from
Nov 27, 2023
Merged

118 code review feedback luke parker #127

merged 23 commits into from
Nov 27, 2023

Conversation

danielmackay
Copy link
Member

Addressing code review feedback in #118.

@danielmackay
Remove razor pages
06dbd89
@danielmackay
All classes now use primary constructors
e908594
@danielmackay
Update guard clause namespace
0fb52b5
@danielmackay
Remove unused code
9a7a241
@danielmackay
Ensure everything is awaited in products/create.cs.
fb1c1f4
@danielmackay
Fixed up async/await and nullability warnings in test code
622c064
@danielmackay
Removed commented code from NorthwindDbContextInitializerTests.cs
70a55fc
@danielmackay
Fixed up async/await in CreateCustomerCommandTests.cs
ea4705e
@danielmackay
Fixed hardcoded string for collection definition.
dc5c80c
@danielmackay
Added more efficient dictionary parsing to ExceptionFilter.cs.
0c9ffb8
@danielmackay
Added missing Async() call in DeleteCustomerCommand.cs
1695158
@danielmackay
Moved ICsvFileBuilder.cs out of Common
755ffff
@danielmackay
Removed uneeded usings
849f613
@danielmackay
Tidied up test setup data
bc4a73d
@danielmackay
Removed uneeded CommandTestBase.cs.
bdd1733
@danielmackay
Moved logic to check if a customer can be deleted to the Domain.
e4e3263
@danielmackay
Events are now created from the Domain and published via an Interceptor.
99f83a1
@danielmackay
Pushed validation into the Domain layer
2c6d24b
@danielmackay
Removed unit tests that used in-memory DbContext.
ac7aea8
@danielmackay
Fixed tests.
41aa616
@danielmackay
Added better domain tests.
90a8cb2
@danielmackay danielmackay requested a review from Hona November 21, 2023 06:12
@danielmackay danielmackay linked an issue Nov 21, 2023 that may be closed by this pull request
💪👀 Code Review Feedback - Luke Parker #118
Closed
@danielmackay danielmackay merged commit 5affa2d into main Nov 27, 2023
2 checks passed
@danielmackay danielmackay deleted the 118-code-review-feedback-luke-parker branch November 27, 2023 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hona Hona Hona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

💪👀 Code Review Feedback - Luke Parker
2 participants
@danielmackay @Hona