Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Download #128

Merged
merged 2 commits into from
Dec 14, 2023
Merged

CSV Download #128

merged 2 commits into from
Dec 14, 2023

Conversation

christoment
Copy link
Contributor

@christoment christoment commented Dec 14, 2023

Resolves #109

feat:

  • Added CSV download for customers
  • Change CSV service approach to allow expansion via type mapper
  • Change how file download (now via JS instead of via a href (pros & cons)

Note: I tried to process it as stream but I couldn't find a nice way to return FileStreamResult without writing it on Controller... So at the moment we are still reading it fully as byte array and then just return this as is.

Copy link
Member

@danielmackay danielmackay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@christoment christoment merged commit ac0385b into main Dec 14, 2023
2 checks passed
@christoment christoment deleted the features/109-csv-download branch December 14, 2023 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

💪✨ Customers - Implement CSV Download
2 participants