Radium dataflow #1007

MathiasPaulin · 2022-09-29T11:02:56Z

Pull Request Desription

Add dataflow programming capabilities to the Radium engine (draft)

TODO

clarify ownership transfer of the nodes to the graph
clearly state that naked pointers got from the graph are non owning pointers.
add rendering component (NOT IN THIS PR)
add documentation and programming guide (WIP)
transform demos to unittests

codecov · 2022-10-11T05:00:05Z

Codecov Report

Merging #1007 (daa40ef) into release-candidate (a349c0c) will increase coverage by 2.62%.
Report is 1 commits behind head on release-candidate.
The diff coverage is 71.13%.

❗ Current head daa40ef differs from pull request most recent head 305c81a. Consider uploading reports for the commit 305c81a to get more accurate results

@@                  Coverage Diff                  @@
##           release-candidate    #1007      +/-   ##
=====================================================
+ Coverage              45.65%   48.28%   +2.62%     
=====================================================
  Files                    312      351      +39     
  Lines                  23063    25722    +2659     
=====================================================
+ Hits                   10530    12420    +1890     
- Misses                 12533    13302     +769

Files Changed	Coverage Δ
src/Dataflow/Core/Enumerator.hpp	`0.00% <0.00%> (ø)`
...ataflow/QtGui/GraphEditor/ConnectionStatusData.hpp	`0.00% <0.00%> (ø)`
src/Dataflow/QtGui/GraphEditor/GraphEditorView.cpp	`0.00% <0.00%> (ø)`
...c/Dataflow/QtGui/GraphEditor/GraphEditorWindow.cpp	`0.00% <0.00%> (ø)`
...c/Dataflow/QtGui/GraphEditor/GraphEditorWindow.hpp	`0.00% <0.00%> (ø)`
...rc/Dataflow/QtGui/GraphEditor/NodeAdapterModel.cpp	`0.00% <0.00%> (ø)`
...rc/Dataflow/QtGui/GraphEditor/NodeAdapterModel.hpp	`0.00% <0.00%> (ø)`
src/Dataflow/QtGui/GraphEditor/WidgetFactory.cpp	`0.00% <0.00%> (ø)`
src/Dataflow/QtGui/GraphEditor/WidgetFactory.hpp	`0.00% <0.00%> (ø)`
src/Engine/Data/EnvironmentTexture.cpp	`72.88% <ø> (ø)`
... and 33 more

... and 2 files with indirect coverage changes

dlyr

review in progress

external/Core/CMakeLists.txt

src/Core/Random/RandomPointSet.hpp

doc/concepts/nodesystem.md

examples/DataflowExamples/HelloGraph/main.cpp

Make data private and also use port shared ptr

Instead of two sets.

BinaryOpNode FilterNode SingleDataSourceNode

Also start gather logging and new addLink with port only

move oneline in class definition move template outside class definition in header move bigger method in .cpp reorder a bit

Add getter, and also reorder public/protected/private to have only one section of each.

…h g++).

As suggested by codacy.

Use more type alias FindNode2 recurs on graph node SinkNode and FonctionNode port getter

MathiasPaulin added enhancement Type of issue/PR: enhancement Feature Request Type of issue: feature request WIP Work in Progress labels Sep 29, 2022

MathiasPaulin requested a review from dlyr September 29, 2022 11:02

MathiasPaulin force-pushed the Radium-dataflow branch 2 times, most recently from 177728c to 8a8a74f Compare September 29, 2022 18:49

dlyr removed their request for review October 4, 2022 19:16

MathiasPaulin force-pushed the Radium-dataflow branch from 10b3f41 to 100b6f2 Compare October 6, 2022 07:33

MathiasPaulin force-pushed the Radium-dataflow branch 8 times, most recently from d658ada to 5597064 Compare October 17, 2022 14:08

MathiasPaulin marked this pull request as ready for review October 20, 2022 15:03

MathiasPaulin requested review from dlyr and nmellado October 20, 2022 15:03

dlyr reviewed Oct 25, 2022

View reviewed changes

external/Core/CMakeLists.txt Show resolved Hide resolved

src/Core/Random/RandomPointSet.hpp Outdated Show resolved Hide resolved

MathiasPaulin force-pushed the Radium-dataflow branch 2 times, most recently from ee53b1d to 4023491 Compare November 2, 2022 11:46

MathiasPaulin mentioned this pull request Nov 4, 2022

Radium dataflow rendering #1018

Draft

6 tasks

dlyr reviewed Nov 8, 2022

View reviewed changes

doc/concepts/nodesystem.md Show resolved Hide resolved

doc/concepts/nodesystem.md Outdated Show resolved Hide resolved

examples/DataflowExamples/HelloGraph/main.cpp Outdated Show resolved Hide resolved

dlyr marked this pull request as draft December 7, 2022 12:21

MathiasPaulin force-pushed the Radium-dataflow branch from 89f4ed6 to a4d7d7a Compare January 31, 2023 13:28

MathiasPaulin force-pushed the Radium-dataflow branch from e1f7cbb to 3f243ac Compare February 10, 2023 17:33

MathiasPaulin force-pushed the Radium-dataflow branch 2 times, most recently from 6af0cfb to aae1e1d Compare February 27, 2023 11:25

dlyr added 30 commits September 20, 2023 09:51

[dataflow-core] small changes on node.

d91c476

[dataflow-core] Start using shared ptr for port

84859d0

[examples] start updating dataflow examples

4c16782

[examples] simplify HelloGraph

06ee43e

[dataflow-core] Use pass by copy and move for set data.

7a96b54

Make data private and also use port shared ptr

[examples][tests] Update according to setData

71a5135

[dataflow-core] silently pass this in Node::add*Port

d7c007b

[dataflow-core] add some port getter constness.

881557a

[tests] test typo in comment

6410807

[dataflow-core] Wip on new addlink.

d01c05e

[dataflow-core] Add PortOut ctor with data.

64199ed

[dataflow-core] use needsRecompile() to set bool values.

65479cd

Instead of two sets.

[dataflow-core] Add port getter, return index and ptr.

966a686

[dataflow-core] add typed access to port

ecfc94e

BinaryOpNode FilterNode SingleDataSourceNode

[examples] use typed add link in hellograph.

76aed8c

[dataflow-core] GetPort -> Get, move some method in protected.

96d27d1

[dataflow-core] Node return type consistency

da9f1f4

Also start gather logging and new addLink with port only

[dataflow-core] Node serialization comments and messages.

1e981be

[dataflow-core] Function source refactor using port shared ptr.

5e85823

[dataflow-core] Use node ptr using and base json implem.

14f5fbe

[dataflow-core] Refactor graph

0449599

move oneline in class definition move template outside class definition in header move bigger method in .cpp reorder a bit

[dataflow-core/qtgui] move shouldBeSave private.

e4dad05

Add getter, and also reorder public/protected/private to have only one section of each.

[dataflow-core] remove node constexpr (not working, nor compiling wit…

daab700

…h g++).

fix

11f93b4

[examples] HelloGraph with new addLink.

3443d96

[dataflow-core] Add missing export on inner class.

f03f52f

[dataflow-core] Use initialization list for ports.

d174d68

As suggested by codacy.

[dataflow-core] Clean code, addLink by index check existing port.

de7395b

[dataflow-core] Some refactors

fcb5826

Use more type alias FindNode2 recurs on graph node SinkNode and FonctionNode port getter

[examples] Simplify HelloGraph and add GraphAsNode.

305c81a

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Radium dataflow #1007

Radium dataflow #1007

MathiasPaulin commented Sep 29, 2022 •

edited

Loading

codecov bot commented Oct 11, 2022 •

edited

Loading

dlyr left a comment

Radium dataflow #1007

Are you sure you want to change the base?

Radium dataflow #1007

Conversation

MathiasPaulin commented Sep 29, 2022 • edited Loading

Pull Request Desription

codecov bot commented Oct 11, 2022 • edited Loading

Codecov Report

dlyr left a comment

Choose a reason for hiding this comment

MathiasPaulin commented Sep 29, 2022 •

edited

Loading

codecov bot commented Oct 11, 2022 •

edited

Loading