-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom support for gltf2.0 file format #1061
Open
MathiasPaulin
wants to merge
27
commits into
STORM-IRIT:release-candidate
Choose a base branch
from
MathiasPaulin:io-gltf
base: release-candidate
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add custom support for gltf2.0 file format #1061
MathiasPaulin
wants to merge
27
commits into
STORM-IRIT:release-candidate
from
MathiasPaulin:io-gltf
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MathiasPaulin
added
Core
Related to Ra::Core
Engine
Related to Ra::Engine
IO
Related to Ra::IO
GUI
Related to Ra::Gui
Scripts
examples
labels
Jul 19, 2023
Codecov Report
@@ Coverage Diff @@
## release-candidate #1061 +/- ##
=====================================================
- Coverage 45.65% 38.53% -7.13%
=====================================================
Files 312 346 +34
Lines 23063 27588 +4525
=====================================================
+ Hits 10530 10630 +100
- Misses 12533 16958 +4425
|
…ts only one to Radium)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Add loading/rendering/writing of gltf2.0 files.
gltf is intended for data and material exchanges between content creation tools and renderers.
The gltf specification follows the same principle than OpenGL, Vulkan, ...
See https://www.khronos.org/gltf/ for more information
Implementation follows as much as possible the official specification from
https://registry.khronos.org/glTF/specs/2.0/glTF-2.0.html
The current implementation support only a few extension (at the moment of the PR)
Some extensions (KHR and EXT) will be added in the future in RadiumEngine, others will be available only as a radium client library (e.G. ADOBE, NVIDIA, ...) see https://github.com/KhronosGroup/glTF/tree/main/extensions/2.0.
Please check if the PR fulfills these requirements
Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.
What kind of change does this PR introduce?
What is the current behavior? (You can also link to an open issue here)
gltf2.0 loading using assimp is quite old and non compliant with the specification
What is the new behavior (if this is a feature change)?
loading and rendering of gltf asset is compliant with the specification
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No
Other information:
This PR includes a writer in gltf format, in the IO library. This writer is enabled by default and add dependency of IO library on Engine library. writing gltf files could be disabled (-DRADIUM_IO_GLTF_WRITER=OFF) at configure time. The IO lib compiled after that will not depend on engine.