Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyframe editor #543

Draft
wants to merge 3 commits into
base: release-candidate
Choose a base branch
from

Conversation

hoshiryu
Copy link
Collaborator

@hoshiryu hoshiryu commented Apr 24, 2020

UPDATE the form below to describe your PR.

  • Please check if the PR fulfills these requirements
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Be aware that the PR request cannot be accepted if it doesn't pass the Continuous Integration tests.

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    This PR adds a KeyFramedValue editor to the Timeline UI.
    It is now possible to keyframe (almost) any data (see Docs/timeline.md for more informations).

  • What is the current behavior? (You can also link to an open issue here)

  • What is the new behavior (if this is a feature change)?

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

  • Other information:

Should be merged after #542

See also branches animate_camera and timeline_examples from the plugins repository, for practical examples on how to animate an entity and a camera transform or the position / normal of a mesh vertex (not finalized though).

@stale stale bot added the wontfix PR/Issue that will not be fixed label May 27, 2020
@hoshiryu hoshiryu removed the wontfix PR/Issue that will not be fixed label May 27, 2020
@STORM-IRIT STORM-IRIT deleted a comment from stale bot May 27, 2020
@hoshiryu hoshiryu force-pushed the keyframe_editor branch 2 times, most recently from 5bcf05c to 5f08274 Compare June 5, 2020 15:03
@stale
Copy link

stale bot commented Jul 5, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix PR/Issue that will not be fixed label Jul 5, 2020
@hoshiryu hoshiryu removed the wontfix PR/Issue that will not be fixed label Jul 5, 2020
@nmellado
Copy link
Contributor

nmellado commented Jul 9, 2020

Codacy Here is an overview of what got changed by this pull request:

Clones added
============
- src/GuiBase/KeyFrameEditor/KeyFrameEditorScrollArea.cpp  3
- src/GuiBase/KeyFrameEditor/KeyFrameEditorFrame.hpp  2
- src/GuiBase/KeyFrameEditor/KeyFrameEditorFrame.cpp  13
- src/GuiBase/KeyFrameEditor/KeyFrameEditor.hpp  1
- src/GuiBase/Timeline/TimelineFrameSelector.hpp  1
- src/GuiBase/KeyFrameEditor/KeyFrameEditorScrollArea.hpp  1
         

See the complete overview on Codacy

@stale
Copy link

stale bot commented Aug 8, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix PR/Issue that will not be fixed label Aug 8, 2020
@nmellado nmellado removed the wontfix PR/Issue that will not be fixed label Aug 8, 2020
@stale
Copy link

stale bot commented Sep 7, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix PR/Issue that will not be fixed label Sep 7, 2020
@nmellado nmellado removed the wontfix PR/Issue that will not be fixed label Sep 7, 2020
@stale
Copy link

stale bot commented Oct 7, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix PR/Issue that will not be fixed label Oct 7, 2020
@stale stale bot closed this Oct 15, 2020
@nmellado nmellado reopened this Oct 15, 2020
@stale stale bot removed the wontfix PR/Issue that will not be fixed label Oct 15, 2020
hoshiryu added 3 commits December 9, 2020 13:25
@nmellado
Copy link
Contributor

Do we keep this PR open ?
It has several conflicts, is someone confident to fix it ?

@dlyr
Copy link
Contributor

dlyr commented May 27, 2021

Let's make it draft, I'll keep it in the todo list (we can also clean an postpone ...)

@nmellado nmellado marked this pull request as draft May 28, 2021 11:32
@nmellado nmellado changed the base branch from master to release-candidate September 21, 2022 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants