Open Telemetry and Docker #315
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mdemare
force-pushed
the
opentelemetry
branch
5 times, most recently
from
d456dc3
to
48144f0
Compare
remvee
requested changes
Jun 26, 2024
Makefile
Outdated
| rm -rf classes target | ||
|
|
||
| opentelemetry-javaagent.jar: | ||
| curl -L https://github.com/open-telemetry/opentelemetry-java-instrumentation/releases/latest/download/opentelemetry-javaagent.jar -o $@ |
There was a problem hiding this comment.
Lijkt me niet heel verstandig "latest" te gebruiken omdat het maken van een docker image nog minder deterministisch maakt. Tegelijkertijd moeten we dan wel gaan tracken welke versie van opentelemetry we gebruiken. Is het niet mogelijk deze jar in onze uberjar op te nemen en daarmee een duidelijk dependency te hebben?
dev-infra/prometheus.yml
Outdated
| @@ -0,0 +1,41 @@ | |||
| # my global config | |||
dev-infra/prometheus.yml
Outdated
|
|
||
| #rule_files: | ||
| # - "first.rules" | ||
| # - "my/*.rules" |
There was a problem hiding this comment.
Dead code? Als dit een zinnig snippet is, documenteren.
dev-infra/prometheus.yml
Outdated
| service: prometheus | ||
| # - targets: ["host.docker.internal:8080"] | ||
| # labels: | ||
| # service: eduhub-gateway |
There was a problem hiding this comment.
Dead code? Als dit een zinnig snippet is, documenteren.
remvee
requested changes
Jul 9, 2024
| COPY --from=builder /app/target/eduhub-rio-mapper.jar /eduhub-rio-mapper.jar | ||
| # Make sure there is an opentelemetry agent in the workdir in case docker-compose | ||
| # starts up a process with -javaagent in the JAVA_TOOL_OPTIONS | ||
| COPY --from=builder /app/vendor/opentelemetry-javaagent-2.2.0.jar /opentelemetry-javaagent.jar |
There was a problem hiding this comment.
Liever geen binaries in de repo en volgens mij wordt deze al gedownload in de makefile (latest weliswaar maar daar heb ik al overgeklaagd)
mdemare
force-pushed
the
opentelemetry
branch
3 times, most recently
from
910d9fc
to
8dae8d9
Compare
remvee
approved these changes
Jul 23, 2024
Use distroless/java as the docker base image again Also: build local docker image in compose, fix some settings Ensure host truststore, keystore and clients config are used when running system in docker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docker compose setup in which to run api, worker, redis and prometheus.
After starting the dev docker container:
api produces metrics on http://localhost:9464/metrics
worker produces metrics on http://localhost:9465/metrics
prometheus runs on http://localhost:9090/
api and worker also produce metrics on their old endpoints. The plan is to move these metrics to the new endpoints, but that hasn't happened yet.