designate: create a test port and nslookup it #3443
Conversation
JanZerebecki
dismissed
their stale review
For new CI runs please ensure want_designate_proposal was set to 1, as that is not the default.
|
I am trying to keep the size of this PR small, and therefore cannot enable testing designate, as its implementation is not entirely merged. The aim of this PR is minimum designate recordset creation test. The CI failure: |
|
Please rebase to fix Travis. |
Added a basic test for designate recordset being created when a floating ip is assigned to a port on a fixed network. ping will not work because the port is still down as it is not assigned to a vm. This helps test designate without nova/glance/cinder/milkyway/... and other astronomical services. Also fixed a type in pools file name.
|
@JanZerebecki @cmurphy could you please have another look at this ? |
JanZerebecki
dismissed
cmurphy’s stale review
CI with want_designate_proposal=1 now passes
scripts/qa_crowbarsetup.sh
Outdated
|
|
||
| # Run Tempest Smoketests if configured to do so | ||
| tempestret=0 | ||
| if [[ $want_tempest = 1 ]]; then | ||
| openstack tld create --name com # needed by designate-template-plugin smoke test |
There was a problem hiding this comment.
What if you don't have designate deployed ? won't this command fail ?
There was a problem hiding this comment.
thats true, let me fix that
designate smoke test try to create a zone and recordset however they expect the tld to already exists. So creating one.
| [[ -e $designate_pools ]] && designate-manage pool update --file $designate_pools | ||
| designate_pools="/etc/designate/pools.crowbar.yaml" | ||
| if [[ -e $designate_pools ]]; then | ||
| designate-manage pool update --file $designate_pools |
There was a problem hiding this comment.
shouldn't this be already done by the barclamp?
There was a problem hiding this comment.
the barclamp leaves a sample pool file /etc/designate/pools.crowbar.yaml" for the admin to review.
Why the barclamp doesnot do this ?
The way designate is currently installed, a zone will be created as soon as a vm is created, the only thing stopping it is "unavailability" of pool in designate. This will have security implication (allowing anyone who can create a vm to create a zone, leaking dns zone information on un-intended network, causing conflicts in dns resolution).
However this is needed to test designate, so adding it here as part of automation.
There was a problem hiding this comment.
This is being taken care of by crowbar/crowbar-openstack#2192
| designate-manage pool update --file $designate_pools | ||
| # default values from the node.neutron.dns_domain | ||
| openstack tld create --name local | ||
| openstack zone create --email admin@example.org openstack.local. |
There was a problem hiding this comment.
shouldn't this be done by the neutron integration of the barclamp?
There was a problem hiding this comment.
without pools, designate cannot create zones, (so they can be XFRd to be resolvable)
Co-Authored-By: Dirk Mueller <dmueller@suse.com>
|
Needs rebase. |
Added a basic test for designate recordset being created when a
floating ip is assigned to a port on a fixed network.
ping will not work because the port is still down as it is not assigned
to a vm. This helps test designate without
nova/glance/cinder/milkyway/... and other astronomical services.
Also fixed a type in pools file name.